Skip to content

[cpprestsdk] Update Boost fix-asio-error.patch#49864

Closed
c72578 wants to merge 1 commit intomicrosoft:masterfrom
c72578:2026-02-07_cpprestsdk_Update_fix-asio-error.patch
Closed

[cpprestsdk] Update Boost fix-asio-error.patch#49864
c72578 wants to merge 1 commit intomicrosoft:masterfrom
c72578:2026-02-07_cpprestsdk_Update_fix-asio-error.patch

Conversation

@c72578
Copy link
Contributor

@c72578 c72578 commented Feb 7, 2026

  • Fix the following error in
  cpprestsdk-2.10.19/Release/tests/functional/pplx/pplx_test/pplx_op_test.cpp:60:27:
  error:
  ‘class boost::asio::io_context’ has no member named ‘post’
   60 |         m_pool->service().post([=]() -> void { proc(param); });
      |                           ^~~~
  • Run ./vcpkg x-add-version --all
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

- Fix the following error in cpprestsdk-2.10.19/Release/tests/
  functional/pplx/pplx_test/pplx_op_test.cpp:60:27: error:
  ‘class boost::asio::io_context’ has no member named ‘post’
   60 |         m_pool->service().post([=]() -> void { proc(param); });
      |                           ^~~~
- Run `./vcpkg x-add-version --all`
@BillyONeal
Copy link
Member

As this error is reported only in test code can it be fixed to just disable the tests instead?

@c72578
Copy link
Contributor Author

c72578 commented Feb 9, 2026

As this error is reported only in test code can it be fixed to just disable the tests instead?

No, this would not fix the error, only circumvent it.

@BillyONeal
Copy link
Member

As this error is reported only in test code can it be fixed to just disable the tests instead?

No, this would not fix the error, only circumvent it.

It does fix the error and would be consistent with our maintainer guide https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#do-not-build-testsdocsexamples-by-default

vcpkg patches are intended to be the minimum possible change that would unblock users, consistent with https://learn.microsoft.com/vcpkg/contributing/maintainer-guide#patching ; and a build system edit is always better than a product code edit in terms of being closer to 'our table'. Patches applied in vcpkg are not intended to be a way to resurrect abandonware; if a project is abandoned and product code changes are necessary to keep it functional we remove the project from the curated registry and do not become effective new upstream maintainers.

As for "cpprestsdk is a bit of a special case given that several vcpkg maintainers were once cpprestsdk maintainers" that was previously litigated in #42678 so I'm not going to go there again.

@BillyONeal BillyONeal marked this pull request as draft February 10, 2026 02:37
@c72578 c72578 closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants