[gettext] Fix wrong variable type

[bansan85]

Fixes #40134

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[BillyONeal]

Is this patch submitted upstream?

[bansan85]

The patch comes from upstream. It's the patch that #40134 is reffering to.

[BillyONeal]

This LGTM with a comment for the next person so they know what to do on updates. I submitted that as bansan85#1

[bansan85]

This LGTM with a comment for the next person so they know what to do on updates. I submitted that as bansan85#1

Thanks. I couldn't use patch from upstream. The downloaded source archive haven't the same path.

And updating gettext version looks to be hard.

[SunBlack]

As there exists newer versions of gettext: Wouldn't it better to update the port and check whether the issue still exists?

[dg0yt]

As there exists newer versions of gettext: Wouldn't it better to update the port and check whether the issue still exists?

Welcome to the struggle with building gettext with MSVC with vcpkg. Currently gnulib libxml hell.

[bansan85]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 49860 in repo microsoft/vcpkg

[bansan85]

gobject-introspection fails. Not my fault (I think). I will try again in few days...

[dg0yt]

gobject-introspection fails. Not my fault (I think). I will try again in few days...

Appeared between https://dev.azure.com/vcpkg/public/_build/results?buildId=126854&view=results and https://dev.azure.com/vcpkg/public/_build/results?buildId=126963&view=results, but nothing obvious.

[SunBlack]

gobject-introspection fails. Not my fault (I think). I will try again in few days...

I don't think a few days will resolve this issue 😅 . I digged a bit into this issue:

• gobject-introspection relies on distutils, which was part of Python until 3.11
• distutils is migrated to setuptools, but with breaking changes, as the signature of the init method changed (if AI is correct)
• vcpkg is using Python 3.12 with setuptools-82.0.0. Therefore you run into this issue

Seems they missed to adjust sth. for setuptools (they check for Python 3.12+ - probably they are just not testing MSVC). Feel free to report this to them - maybe they know a solution for this.

[bansan85]

Issue: https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/575

Solution: https://github.com/conda-forge/gobject-introspection-feedstock/pull/89/changes#diff-e8252470105f12d385bbeb76af4c40536dc86d5a860103449ed5fd4d199e1ccc

[BillyONeal]

Thanks. I couldn't use patch from upstream. The downloaded source archive haven't the same path.

It's close enough that I think the comment describes where it came from even if that exact patch isn't what's being applied here.

[bansan85]

@BillyONeal can you please reopen this MR ? It was wrongly closed by #49918. Thanks

[BillyONeal]

Thanks!