Skip to content

[easy-profiler] add new port#49812

Merged
BillyONeal merged 5 commits into
microsoft:masterfrom
easyflex:easyprofiler
Feb 5, 2026
Merged

[easy-profiler] add new port#49812
BillyONeal merged 5 commits into
microsoft:masterfrom
easyflex:easyprofiler

Conversation

@robbert-ef
Copy link
Copy Markdown
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Comment on lines +1 to +18
{
"name": "easyprofiler",
"version": "2.1.0",
"description": "Lightweight profiler library for c++",
"homepage": "https://github.com/yse/easy_profiler",
"license": "MIT",
"supports": "!uwp",
"dependencies": [
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
]
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vcpkg format-manifest ports/easyprofiler/vcpkg.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "we should make that a check" and then I remembered we actually did and that's why it's red 😅

Comment on lines +9 to +14
vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DEASY_PROFILER_NO_GUI=ON
-DEASY_PROFILER_NO_SAMPLES=ON
)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DEASY_PROFILER_NO_GUI=ON
-DEASY_PROFILER_NO_SAMPLES=ON
)
vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DEASY_PROFILER_NO_GUI=ON
-DEASY_PROFILER_NO_SAMPLES=ON
)

This, and similar everywhere else.

Comment thread ports/easyprofiler/vcpkg.json Outdated
Comment thread ports/easyprofiler/vcpkg.json Outdated
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a PR to fix the whitespace nitpicks easyflex#1

The license and name need to be fixed.

@BillyONeal BillyONeal marked this pull request as draft February 5, 2026 00:30
@robbert-ef robbert-ef marked this pull request as ready for review February 5, 2026 09:39
@BillyONeal BillyONeal changed the title [easyprofiler] add new port [easy-profiler] add new port Feb 5, 2026
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the name and double checking the license

@BillyONeal BillyONeal merged commit c71d704 into microsoft:master Feb 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants