[easy-profiler] add new port#49812
Merged
Merged
Conversation
dg0yt
reviewed
Feb 4, 2026
Comment on lines
+1
to
+18
| { | ||
| "name": "easyprofiler", | ||
| "version": "2.1.0", | ||
| "description": "Lightweight profiler library for c++", | ||
| "homepage": "https://github.com/yse/easy_profiler", | ||
| "license": "MIT", | ||
| "supports": "!uwp", | ||
| "dependencies": [ | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake-config", | ||
| "host": true | ||
| } | ||
| ] | ||
| } |
Contributor
There was a problem hiding this comment.
vcpkg format-manifest ports/easyprofiler/vcpkg.json
Member
There was a problem hiding this comment.
I would say "we should make that a check" and then I remembered we actually did and that's why it's red 😅
Comment on lines
+9
to
+14
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DEASY_PROFILER_NO_GUI=ON | ||
| -DEASY_PROFILER_NO_SAMPLES=ON | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| vcpkg_cmake_configure( | |
| SOURCE_PATH "${SOURCE_PATH}" | |
| OPTIONS | |
| -DEASY_PROFILER_NO_GUI=ON | |
| -DEASY_PROFILER_NO_SAMPLES=ON | |
| ) | |
| vcpkg_cmake_configure( | |
| SOURCE_PATH "${SOURCE_PATH}" | |
| OPTIONS | |
| -DEASY_PROFILER_NO_GUI=ON | |
| -DEASY_PROFILER_NO_SAMPLES=ON | |
| ) |
This, and similar everywhere else.
BillyONeal
reviewed
Feb 5, 2026
BillyONeal
reviewed
Feb 5, 2026
BillyONeal
requested changes
Feb 5, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
I submitted a PR to fix the whitespace nitpicks easyflex#1
The license and name need to be fixed.
BillyONeal
approved these changes
Feb 5, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for fixing the name and double checking the license
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.