Skip to content

[fast-float] update to 8.2.3#49788

Merged
BillyONeal merged 1 commit into
microsoft:masterfrom
nyoma-diamond:fast-float-8.2.3
Feb 5, 2026
Merged

[fast-float] update to 8.2.3#49788
BillyONeal merged 1 commit into
microsoft:masterfrom
nyoma-diamond:fast-float-8.2.3

Conversation

@nyoma-diamond
Copy link
Copy Markdown
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@nyoma-diamond nyoma-diamond marked this pull request as draft February 3, 2026 17:16
@nyoma-diamond
Copy link
Copy Markdown
Contributor Author

nyoma-diamond commented Feb 3, 2026

UWP failures appear to be a problem with downstream xlnt. Occurs when trying to fetch libstudxml via git. Seems like a misconfiguration there. Not clear why this only happens on UWP, though.

stdout-[x/arm]64-uwp.log:

...
Download successful! Asset cache hit, did not try authoritative source https://github.com/xlnt-community/xlnt/archive/v1.6.1.tar.gz
-- Extracting source D:/downloads/xlnt-1.6.1.tar.gz
-- Applying patch fix-not-found-include.patch
-- Applying patch fix-configure-dependencies.patch
-- Using source at D:/b/xlnt/src/xlnt-1-6a5c9e18ee.clean
-- Fetching https://git.codesynthesis.com/libstudxml/libstudxml.git v1.1.0-b.10+2...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: C:/vss-agent/4.268.0/externals/git/cmd/git.exe fetch https://git.codesynthesis.com/libstudxml/libstudxml.git v1.1.0-b.10+2 --unshallow -n
    Working Directory: D:/downloads/git-tmp
    Error code: 128
    See logs for more information:
      D:\b\xlnt\git-fetch-[x/arm]64-uwp-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_git.cmake:86 (vcpkg_execute_required_process)
  ports/xlnt/portfile.cmake:20 (vcpkg_from_git)
  scripts/ports.cmake:206 (include)

git-fetch-[x/arm]64-uwp-err.log:

fatal: --unshallow on a complete repository does not make sense

@nyoma-diamond
Copy link
Copy Markdown
Contributor Author

nyoma-diamond commented Feb 3, 2026

Oops, didn't see it also failed for arm64_windows. Same error though.
Others that have run so far pass because they don't attempt to install xlnt, so it's definitely not environment dependent

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Feb 3, 2026

vcpkg_from_git has no asset caching... IMHO it should be banned for ports in this registry.

--unshallow came with #49293 five days ago.

@BillyONeal
Copy link
Copy Markdown
Member

--unshallow came with #49293 five days ago.

We're reverting it :)

@nyoma-diamond nyoma-diamond marked this pull request as ready for review February 4, 2026 08:08
@nyoma-diamond
Copy link
Copy Markdown
Contributor Author

with #49792 merged can we rerun these checks and merge this? :)

@BillyONeal BillyONeal closed this Feb 4, 2026
@BillyONeal BillyONeal reopened this Feb 4, 2026
@BillyONeal
Copy link
Copy Markdown
Member

with #49792 merged can we rerun these checks and merge this? :)

Just a rerun is insufficient, needs a re-merge to pick up that change. I tried closing and reopening to trigger that but it does not always work...

@BillyONeal
Copy link
Copy Markdown
Member

The x64-linux failure is a baseline issue and I would merge through that. Will look for other build results....

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BillyONeal BillyONeal merged commit 11d6f5a into microsoft:master Feb 5, 2026
16 of 18 checks passed
@nyoma-diamond nyoma-diamond deleted the fast-float-8.2.3 branch February 6, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants