Closed
Conversation
This seemed to work in my testing in microsoft#47156 (comment)
Member
Author
|
(Note build failure is intentional right now because I intentionally did not update version DB because I want to see what results come back) |
Member
Author
|
@dg0yt Do you remember why you added that "supports"? |
Contributor
|
Looking up the PR, #47815:
The header-only installation will never fail. Set |
Member
Author
Ah, there's the errors: C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(56): error C2065: 'OPENFILENAME': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(56): error C2146: syntax error: missing ';' before identifier 'ofn'
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(56): error C2065: 'ofn': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(60): error C2065: 'ofn': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(61): error C2065: 'ofn': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(61): error C2065: 'ofn': undeclared identifierMakes sense that the classic dialogs aren't a thing in UWP mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed to work in my testing in #47156 (comment)
Related: #47815