Skip to content

[libigl] Mark supports UWP.#48278

Closed
BillyONeal wants to merge 1 commit intomicrosoft:masterfrom
BillyONeal:support-uwp-libigl
Closed

[libigl] Mark supports UWP.#48278
BillyONeal wants to merge 1 commit intomicrosoft:masterfrom
BillyONeal:support-uwp-libigl

Conversation

@BillyONeal
Copy link
Member

This seemed to work in my testing in #47156 (comment)

Related: #47815

This seemed to work in my testing in microsoft#47156 (comment)
@BillyONeal BillyONeal marked this pull request as draft November 13, 2025 22:40
@BillyONeal
Copy link
Member Author

(Note build failure is intentional right now because I intentionally did not update version DB because I want to see what results come back)

@BillyONeal
Copy link
Member Author

@dg0yt Do you remember why you added that "supports"?

@dg0yt
Copy link
Contributor

dg0yt commented Nov 14, 2025

Looking up the PR, #47815:

But in the end, I restored the header-only configuration, now subject to a triplet variable.

The header-only installation will never fail.
The test port cascades due to glfw.

Set LIBIGL_USE_STATIC_LIBRARY to 1 in the triplet to actually compile code for UWP.

@BillyONeal
Copy link
Member Author

Set LIBIGL_USE_STATIC_LIBRARY to 1 in the triplet to actually compile code for UWP.

Ah, there's the errors:

C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(56): error C2065: 'OPENFILENAME': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(56): error C2146: syntax error: missing ';' before identifier 'ofn'
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(56): error C2065: 'ofn': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(60): error C2065: 'ofn': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(61): error C2065: 'ofn': undeclared identifier
C:\Dev\vcpkg\buildtrees\libigl\src\v2.6.0-4736a7a7d0.clean\include\igl\file_dialog_save.cpp(61): error C2065: 'ofn': undeclared identifier

Makes sense that the classic dialogs aren't a thing in UWP mode

@BillyONeal BillyONeal closed this Nov 14, 2025
@BillyONeal BillyONeal deleted the support-uwp-libigl branch November 14, 2025 20:07
@BillyONeal BillyONeal mentioned this pull request Nov 14, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants