[hazelcast-cpp-client] Add new port #48090
Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom Nov 17, 2025
Merged
Conversation
Member
|
Note that we used to have this, but it was removed in #42678 over the boost compatibility issues. We'll need the build failures identified by PR build to be fixed before we can merge this. When that's fixed please mark "Ready for review" so that we know to look again. |
Contributor
Author
@BillyONeal Yes, we fixed it to work with new Boost versions. See our builds here as a proof. e.g. this one uses Boost 1.89.0. We test for old and new boost versions as well. |
Member
|
Perhaps I should clarify: I just guessed that it may be Boost related because that's what happened before. But the build failures need to be fixed before we can merge this even if they aren't related to Boost. |
Contributor
Author
@BillyONeal Hello, I could not generate the failure on my local. I run these and they work on my local: Can you help me how I can generate the build failure on my local? |
Member
|
Perhaps somehow you have a git 'ambiently available' and that's not true in our lab? The thing that looks most "error-ish" is this Perhaps that needs to be [1/2] "/opt/homebrew/bin/cmake" -E chdir ".." "/opt/homebrew/bin/cmake" "/Users/vcpkg/Data/b/hazelcast-cpp-client/src/ea7a924fb4-ef8d1dacae.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=/Users/vcpkg/Data/p/hazelcast-cpp-client_arm64-osx" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DWITH_OPENSSL=OFF" "-DBUILD_EXAMPLES=OFF" "-DCMAKE_MAKE_PROGRAM=/opt/homebrew/bin/ninja" "-DCMAKE_SYSTEM_NAME=Darwin" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/Users/vcpkg/Data/work/1/s/scripts/toolchains/osx.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-osx" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=/Users/vcpkg/Data/work/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=/Users/vcpkg/Data/work/1/s" "-D_VCPKG_INSTALLED_DIR=/Users/vcpkg/Data/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_OSX_ARCHITECTURES=arm64"
FAILED: [code=1] ../CMakeCache.txt
"/opt/homebrew/bin/cmake" -E chdir ".." "/opt/homebrew/bin/cmake" "/Users/vcpkg/Data/b/hazelcast-cpp-client/src/ea7a924fb4-ef8d1dacae.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=/Users/vcpkg/Data/p/hazelcast-cpp-client_arm64-osx" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DWITH_OPENSSL=OFF" "-DBUILD_EXAMPLES=OFF" "-DCMAKE_MAKE_PROGRAM=/opt/homebrew/bin/ninja" "-DCMAKE_SYSTEM_NAME=Darwin" "-DBUILD_SHARED_LIBS=OFF" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/Users/vcpkg/Data/work/1/s/scripts/toolchains/osx.cmake" "-DVCPKG_TARGET_TRIPLET=arm64-osx" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=external" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=/Users/vcpkg/Data/work/1/s/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=arm64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=/Users/vcpkg/Data/work/1/s" "-D_VCPKG_INSTALLED_DIR=/Users/vcpkg/Data/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_OSX_ARCHITECTURES=arm64"
-- The CXX compiler identification is AppleClang 17.0.0.17000013
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:29 (configure_file):
No such file or directory
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
CMake Warning at cmake/utils.cmake:24 (message):
Could not execute command git show for obtaining the git commit date.
Process exited with 128.
Call Stack (most recent call first):
CMakeLists.txt:50 (get_commit_date_and_id)
CMake Warning at cmake/utils.cmake:35 (message):
Could not execute command git show for obtaining the git commit id.
Process exited with 128.
Call Stack (most recent call first):
CMakeLists.txt:50 (get_commit_date_and_id)
-- GIT_COMMIT_DATE = NOT_FOUND
-- GIT_COMMIT_ID = NOT_FOUND
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
CMake Warning (dev) at /Users/vcpkg/Data/installed/arm64-osx/share/boost/vcpkg-cmake-wrapper.cmake:3 (_find_package):
Policy CMP0167 is not set: The FindBoost module is removed. Run "cmake
--help-policy CMP0167" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
Call Stack (most recent call first):
/Users/vcpkg/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:858 (include)
CMakeLists.txt:89 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.
-- Found Boost: /Users/vcpkg/Data/installed/arm64-osx/share/boost/BoostConfig.cmake (found suitable version "1.89.0", minimum required is "1.73") found components: thread chrono
-- Boost version: 1.89.0
-- Boost include directory: /Users/vcpkg/Data/installed/arm64-osx/include
-- Boost libraries: Boost::thread;Boost::chrono
-- Boost version 1.89.0 >= 1.82.0, setting C++ standard to 14. Boost.Math library requires minimum C++14 compiler.
-- CMAKE_CXX_COMPILER_ID = AppleClang
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Configuration summary:
-- CMAKE_BUILD_TYPE = Release
-- BUILD_SHARED_LIBS = OFF
-- WITH_OPENSSL = OFF
-- DISABLE_LOGGING = OFF
-- CMAKE_INSTALL_PREFIX = /Users/vcpkg/Data/p/hazelcast-cpp-client_arm64-osx
-- BUILD_TESTS = OFF
-- BUILD_EXAMPLES = OFF
-- CMAKE_CXX_FLAGS = -fPIC
-- CMAKE_CXX_FLAGS_DEBUG = -g
-- CMAKE_CXX_FLAGS_RELEASE = -O3 -DNDEBUG
-- Configuring incomplete, errors occurred! |
Contributor
Author
|
Hello @BillyONeal Is there a way to see the log for file /mnt/vcpkg-ci/b/hazelcast-cpp-client/config-x64-linux-rel-CMakeConfigureLog.yaml.log or /mnt/vcpkg-ci/b/hazelcast-cpp-client/config-x64-linux-rel-ninja.log , etc? I could not locate them. It says the ninja command failed but no reason why it failed. |
Contributor
|
The link to the instruction is in the logged messages. Does this need further improvement? |
…nerating the reference_manual.md file which may be a problem when the pr builder runs the checks in parallel trying to modify the same file.
Contributor
Author
|
@BillyONeal can you review? |
BillyONeal
approved these changes
Nov 17, 2025
Member
|
Thanks! |
Member
I think the only improvement that will REALLY matter is adopting GitHub Actions. But we tried that and their absolute 6 hour time limit kinda made it nonviable for us :( |
luadebug
pushed a commit
to luadebug/vcpkg
that referenced
this pull request
Nov 21, 2025
geiseri
pushed a commit
to geiseri/vcpkg
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the hazelcast-cpp-client port.
fixes hazelcast/hazelcast-cpp-client#1247 (comment)
fixes #44360
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.