-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[openssl] Fix x86 builds [vcpkg baseline][qtwebengine] Change include dir order #47710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Upstreaming: openssl/openssl#28792 |
|
Of course port qtwebengine has now an installation order problem with the new port dawn, similar to the protobuf problem just solved 😢 |
|
Okay, qtwebengine include dirs need more work. OTOH i have more data. |
|
So Qt6Gui pulls in Vulkan headers which pulls in the top level include dir. Propagated via the generated src/core/.../gn_config_cxx.cmake and cmake/QtGenGn.cmake to src/core/configure/BUILD.root.gn.in to QtWebengineCore config in generatedBUILD.gn. We can have Qt dirs before chromium dirs, but moving the top-level include dir? QtWebengine has uses vendored dependencies on Windows and vcpkg dependencies on non-Windows. |
This comment was marked as resolved.
This comment was marked as resolved.
|
It probably needs #47762? |
Fixes #47703.
Fixes qtwebengine regressions subject to installation order by putting include dirs from CMake/vcpkg behind the include dirs from gn/chromium.
IOW moving them from "2" (configs: QtWebengineCore_config) to "6" (deps: QtWebengineCore_include_dirs) wrt https://gn.googlesource.com/gn/+/master/docs/reference.md#var_include_dirs. gn/chromium include dirs come from "6".