Skip to content

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 8, 2025

Fixes #47703.

Fixes qtwebengine regressions subject to installation order by putting include dirs from CMake/vcpkg behind the include dirs from gn/chromium.
IOW moving them from "2" (configs: QtWebengineCore_config) to "6" (deps: QtWebengineCore_include_dirs) wrt https://gn.googlesource.com/gn/+/master/docs/reference.md#var_include_dirs. gn/chromium include dirs come from "6".

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 8, 2025

Upstreaming: openssl/openssl#28792

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 10, 2025

Of course port qtwebengine has now an installation order problem with the new port dawn, similar to the protobuf problem just solved 😢

@dg0yt dg0yt changed the title [openssl] Fix x86 builds [openssl] Fix x86 builds [vcpkg baseline][qtwebengine] Change include order for dawn Oct 10, 2025
@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 10, 2025

Okay, qtwebengine include dirs need more work. OTOH i have more data.

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 10, 2025

So Qt6Gui pulls in Vulkan headers which pulls in the top level include dir.

Propagated via the generated src/core/.../gn_config_cxx.cmake and cmake/QtGenGn.cmake to src/core/configure/BUILD.root.gn.in to QtWebengineCore config in generatedBUILD.gn.
Include dirs from public configs (QtWebengineCore config) appear before include dirs from gn dependencies (chromium).

https://gn.googlesource.com/gn/+/master/docs/reference.md#variables-you-set-in-targets-all_dependent_configs_configs-to-be-forced-on-dependents_back-to-top-ordering-of-flags-and-values

We can have Qt dirs before chromium dirs, but moving the top-level include dir? QtWebengine has uses vendored dependencies on Windows and vcpkg dependencies on non-Windows.

@dg0yt dg0yt changed the title [openssl] Fix x86 builds [vcpkg baseline][qtwebengine] Change include order for dawn [openssl] Fix x86 builds [vcpkg baseline][qtwebengine] Change include dir order Oct 12, 2025
@dg0yt

This comment was marked as resolved.

@dg0yt dg0yt mentioned this pull request Oct 12, 2025
@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 12, 2025

It probably needs #47762?

@dg0yt dg0yt marked this pull request as ready for review October 13, 2025 16:49
@BillyONeal BillyONeal closed this Oct 13, 2025
@BillyONeal BillyONeal reopened this Oct 13, 2025
@BillyONeal BillyONeal added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 13, 2025
@BillyONeal BillyONeal enabled auto-merge (squash) October 14, 2025 16:42
@BillyONeal BillyONeal merged commit df2a2af into microsoft:master Oct 14, 2025
19 checks passed
@dg0yt dg0yt deleted the openssl branch October 15, 2025 04:54
@BillyONeal BillyONeal mentioned this pull request Oct 16, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[libzip] build failure on x86-linux after OpenSSL update via #47632

3 participants