Skip to content

[imgui-sfml] Fix dependency opengl #44203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JavierMatosD merged 2 commits into from
Mar 7, 2025
Merged

[imgui-sfml] Fix dependency opengl #44203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418e122
Fix dependency opengl
Mar 6, 2025
2d453aa
update version
Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ports/imgui-sfml/0001-fix_find_package.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ index 7945482..1c91277 100644
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
-target_link_libraries(ImGui-SFML PUBLIC SFML::Graphics OpenGL::GL)
+target_link_libraries(ImGui-SFML PUBLIC imgui::imgui SFML::Graphics OpenGL::GL)
+target_link_libraries(ImGui-SFML PUBLIC imgui::imgui SFML::Graphics ${OPENGL_LIBRARIES})
Copy link
Contributor

@dg0yt dg0yt Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been nice to add find_dependency and upstream it...

Copy link

@ChrisThrasher ChrisThrasher Mar 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SFML/imgui-sfml@master...fix_install

ImGui-SFML maintainer here 👋🏻

I took a shot at fixing this upstream. If I can find time to properly test this out, I might merge it soon.

EDIT: See SFML/imgui-sfml#316

if(WIN32 AND MINGW)
target_link_libraries(ImGui-SFML PUBLIC imm32)
endif()
Expand Down
1 change: 1 addition & 0 deletions ports/imgui-sfml/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "imgui-sfml",
"version": "3.0",
"port-version": 1,
"description": "ImGui binding for use with SFML",
"homepage": "https://github.com/eliasdaler/imgui-sfml",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3706,7 +3706,7 @@
},
"imgui-sfml": {
"baseline": "3.0",
"port-version": 0
"port-version": 1
},
"imguizmo": {
"baseline": "2024-05-29",
Expand Down
5 changes: 5 additions & 0 deletions versions/i-/imgui-sfml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "061e5f2c8923c6ebe8c9b37ceeb36a8619022f24",
"version": "3.0",
"port-version": 1
},
{
"git-tree": "041c903966c2b455356971e36ae5e8bfec447187",
"version": "3.0",
Expand Down