[double-conversion] Upgrade CMake 3.5#44124
Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom Mar 6, 2025
WangWeiLin-MV:ports/double-conversion/upgrade-cmake-3.5
Merged
[double-conversion] Upgrade CMake 3.5#44124JavierMatosD merged 1 commit intomicrosoft:masterfrom WangWeiLin-MV:ports/double-conversion/upgrade-cmake-3.5
JavierMatosD merged 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/double-conversion/upgrade-cmake-3.5
Conversation
LilyWangLL
approved these changes
Mar 3, 2025
Contributor
|
Isn't it easier to just pass |
Contributor
Author
Thanks for the reminder, it works. vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
+ OPTIONS
+ -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+ MAYBE_UNUSED_VARIABLES
+ CMAKE_POLICY_VERSION_MINIMUM
)Given the patch provided on upstream, I prefer download patch. The method that passing option can be applied to other ports. |
Contributor
|
The CMake 4.0 aspect came up also in #44086. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #43973
Failed due to https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features
Backport google/double-conversion@101e1ba, upgrading min version to 3.5.
Checklist
./vcpkg x-add-version --alland committing the result.Test
The port installation tests pass with the following triplets: