Skip to content

[double-conversion] Upgrade CMake 3.5#44124

Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/double-conversion/upgrade-cmake-3.5
Mar 6, 2025
Merged

[double-conversion] Upgrade CMake 3.5#44124
JavierMatosD merged 1 commit intomicrosoft:masterfrom
WangWeiLin-MV:ports/double-conversion/upgrade-cmake-3.5

Conversation

@WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Mar 3, 2025

Fix #43973

Failed due to https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features

Compatibility with versions of CMake older than 3.5 has been removed.

Backport google/double-conversion@101e1ba, upgrading min version to 3.5.

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port installation tests pass with the following triplets:

  • x64-linux (CMake 4.0.0-rc2)

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Mar 3, 2025
@Neumann-A
Copy link
Contributor

Isn't it easier to just pass -DCMAKE_POLICY_VERSION_MINIMUM=3.5 instead of adding a patch?

@WangWeiLin-MV
Copy link
Contributor Author

Isn't it easier to just pass -DCMAKE_POLICY_VERSION_MINIMUM=3.5 instead of adding a patch?

Thanks for the reminder, it works.

 vcpkg_cmake_configure(
     SOURCE_PATH "${SOURCE_PATH}"
+    OPTIONS
+        -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+    MAYBE_UNUSED_VARIABLES
+        CMAKE_POLICY_VERSION_MINIMUM
 )

Given the patch provided on upstream, I prefer download patch.

The method that passing option can be applied to other ports.

@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review March 4, 2025 03:12
@dg0yt
Copy link
Contributor

dg0yt commented Mar 4, 2025

The CMake 4.0 aspect came up also in #44086.
I came to the conclusion that patching might be preferred, #44086 (comment).

@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 4, 2025
@JavierMatosD JavierMatosD merged commit 5c6ebbc into microsoft:master Mar 6, 2025
18 checks passed
@WangWeiLin-MV WangWeiLin-MV deleted the ports/double-conversion/upgrade-cmake-3.5 branch March 7, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[double-conversion] Build error on x64-windows

5 participants