[ffmpeg] Fix libx264-164.dll file is not copied to bin directory after build#43901
[ffmpeg] Fix libx264-164.dll file is not copied to bin directory after build#43901JonLiu1993 wants to merge 9 commits intomicrosoft:masterfrom
Conversation
| if("tool" IN_LIST FEATURES) | ||
| vcpkg_copy_tools(TOOL_NAMES x264 AUTO_CLEAN) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Fix error:
CMake Error at scripts/cmake/vcpkg_copy_tools.cmake:36 (message):
Couldn't find tool "x264":
"F:/Feature-test/vcpkg/packages/x264_x64-windows/bin/x264.exe" does not exist
There was a problem hiding this comment.
I guess this stumbles over vcpkg's questionable redirecting of --bindir to tools/<PORT>/[debug/]bin. Most autoconf packages put DLLs into bin regardless of that option, but I am not convinced that one should rely on this.
For this port, it might be an alternative to explicitly pass --bindir=[debug/]bin, and do the regular vcpkg_copy_tools afterwards.
ports/x264/portfile.cmake
Outdated
| if(VCPKG_TARGET_IS_WINDOWS AND VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic") | ||
| if (NOT VCPKG_BUILD_TYPE) | ||
| file(COPY "${CURRENT_PACKAGES_DIR}/tools/x264/bin/libx264-164.dll" DESTINATION "${CURRENT_PACKAGES_DIR}/bin") | ||
| file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/bin") |
There was a problem hiding this comment.
| file(MAKE_DIRECTORY "${CURRENT_PACKAGES_DIR}/bin") |
|
#43901 (comment) is not resolved AFAICS. |
|
From what I can see, the issue is in 80d54ff and is in the x264 port, not ffmpeg |
|
Duplicate of #44100 |
Fixes #43802
Fix
libx264-164.dllis not copied to bin directory.SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.