Skip to content

[libgit2] Update portfile.cmake#4387

Closed
kjpus wants to merge 1 commit intomicrosoft:dev/roschuma/4374from
kjpus:libgit2
Closed

[libgit2] Update portfile.cmake#4387
kjpus wants to merge 1 commit intomicrosoft:dev/roschuma/4374from
kjpus:libgit2

Conversation

@kjpus
Copy link
Copy Markdown
Contributor

@kjpus kjpus commented Oct 2, 2018

libgit2 cannot be built to static library with dynamic CRT under Windows. Change the portfile to set STATIC_CRT option based on the value of VCPKG_CRT_LINKAGE in the triplet.

@ras0219-msft
Copy link
Copy Markdown
Contributor

I think this got closed automatically because you proposed it against my development branch.

Could you reopen this against master? Thanks!

@kjpus
Copy link
Copy Markdown
Contributor Author

kjpus commented Oct 9, 2018

Reopened as PR #4432

@kjpus kjpus deleted the libgit2 branch October 11, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants