-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[vcpkg-make,icu,gettext-libintl] use vcpkg-make #43702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
ab0bf7c
c635fed
932a87f
8a16616
e6737c0
b404387
ee85289
c3341fe
d5a9ca8
08cd6f5
675578f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| diff --git a/source/config/mh-msys-msvc b/source/config/mh-msys-msvc | ||
| index 6f50798ebf..2f1a2d6e69 100644 | ||
| --- a/source/config/mh-msys-msvc | ||
| +++ b/source/config/mh-msys-msvc | ||
| @@ -90,10 +90,10 @@ LIBSICU = $(STATIC_PREFIX)$(ICUPREFIX) | ||
| A = lib | ||
|
|
||
| # Cygwin's ar can't handle Win64 right now. So we use Microsoft's tool instead. | ||
| -AR = LIB.EXE#M# | ||
| -ARFLAGS := -nologo $(ARFLAGS:r=)#M# | ||
| +AR = ar-lib lib.exe#M# | ||
| +ARFLAGS := $(ARFLAGS)#M# | ||
| RANLIB = ls -s#M# | ||
| AR_OUTOPT = -OUT:#M# | ||
|
|
||
| ## An import library is needed for z-OS, MSVC and Cygwin | ||
| IMPORT_LIB_EXT = .lib | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,7 +101,7 @@ function(vcpkg_run_autoreconf shell_cmd work_dir) | |
| endfunction() | ||
|
|
||
| function(vcpkg_make_setup_win_msys msys_out) | ||
| list(APPEND msys_require_packages autoconf-wrapper automake-wrapper binutils libtool make which) | ||
| list(APPEND msys_require_packages autoconf-wrapper automake-wrapper autoconf-archive binutils libtool make which) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. setting I added autoconf-archive to the default since the message for linux also contains it and it is used often enough that including it as the default is reasonable.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I needed additonal msys packages also for other ports.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You mean because of #42708 ? That PR adds a dependency on vcpkg-make but does not switch the build to use
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At the time I started #42708, vcpkg-make was too broken.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe the intent was that if one needed something other than the defaults for the caller to call
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it makes sense to include this package since we are recommending it. |
||
| vcpkg_insert_msys_into_path(msys PACKAGES ${msys_require_packages}) | ||
| find_program(PKGCONFIG NAMES pkgconf NAMES_PER_DIR PATHS "${CURRENT_HOST_INSTALLED_DIR}/tools/pkgconf" NO_DEFAULT_PATH) | ||
| set("${msys_out}" "${msys}" PARENT_SCOPE) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.