Skip to content

[alsa] Fix multiple find_package(ALSA REQUIRED)#43008

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
dg0yt:alsa
Jan 2, 2025
Merged

[alsa] Fix multiple find_package(ALSA REQUIRED)#43008
BillyONeal merged 4 commits intomicrosoft:masterfrom
dg0yt:alsa

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 30, 2024

Resolves #42929.

@dg0yt dg0yt mentioned this pull request Dec 30, 2024
@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 30, 2024
@BillyONeal
Copy link
Member

Just to make sure I understand, there are 2 changes here:

  1. Removing what is effectively a debug check that probably shouldn't run during a user's configure.
  2. "Promoting" ALSA_LIBRARY to a cache variable.

and those are really independent changes?

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 31, 2024

Yes, those are two independent changes.

@BillyONeal BillyONeal merged commit fa643c3 into microsoft:master Jan 2, 2025
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the alsa branch January 3, 2025 03:35
@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[imgui,sdl2,alsa] Build error on x64-linux

3 participants