-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7zip] restore missing sources and fix compilation on android #42911
Conversation
@DanAlbert in #41721, for Still skip failures from Android or do more investigation🤔🤔 |
Why should the sources in the |
AFAIK, 7zip uses win32 com api to implement a plugin loading way, so it implements the same api on linux. And Some api are placed in that But in detail should ask the author of the initial port PR. |
Signed-off-by: l.feng <[email protected]>
Signed-off-by: l.feng <[email protected]>
464fb0b
to
7d3db93
Compare
@dg0yt @DanAlbert The failure is timespec_get is broken on android and I have handled it. |
This may be too simplified.
|
Co-authored-by: Kai Pastor <[email protected]>
Co-authored-by: Kai Pastor <[email protected]>
Signed-off-by: l.feng <[email protected]>
Signed-off-by: l.feng <[email protected]>
Signed-off-by: l.feng <[email protected]>
Have added constratins |
Co-authored-by: Kai Pastor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port installation tests pass with the following triplets:
- x64-android
- x64-linux
iirc the problem was that those files call APIs that don't exist on Android (or at least didn't at the |
Fixes #42910
References #41721, #41743