[open62541] Update to 1.3.15, fix android

[dg0yt]

For #42080.

[jimwang118]

The latest upstream version is 1.4.8, please update to the latest version.

[dg0yt]

The latest upstream version is 1.4.8, please update to the latest version.

No, not in this PR.
1.3.15 isn't obsolete. It was released at the same time as 1.4.8 ("last week").
1.4.8 needs Android API level 24. vcpkg CI is at 21.

[Neumann-A]

1.4.8 also doesn't work with qtocupa so....

[BillyONeal]

Are these patches submitted upstream and/or can you explain how to check that they are correct?

[dg0yt]

These patches are trivial. The PR is cherry-picked from #42080 where it fixes downstream linking (qtopcua). Upstream has similar changes in 1.4.

There is no lib rt on Android.
(Upstream has AND NOT ANDROID_NDK_TOOLCHAIN_INCLUDED now, but that's not the right variable.)

There is no need to generally enable sanitizers in clang debug builds. In static builds, sanitizers impose transitive usage requirements.
The patch is just equivalent to if(0). (Upstream has UA_ENABLE_DEBUG_SANITIZER now.)

[jimwang118]

All feature test passed with x64-android triplet.

[BillyONeal]

These patches are trivial. The PR is cherry-picked from #42080 where it fixes downstream linking (qtopcua).

Sure, I wasn't trying to claim that they were not trivial. Just because they're trivial doesn't mean I'm not taking responsibility for them when merged though, so I still want some understanding of what they're doing.

Upstream has similar changes in 1.4.
[...]
There is no lib rt on Android.
(Upstream has AND NOT ANDROID_NDK_TOOLCHAIN_INCLUDED now, but that's not the right variable.)

OK, I'm happy that this is morally equivalent to https://github.com/open62541/open62541/blob/642cf4b59d9ac99675f3ccdc33ef1314c21b454a/CMakeLists.txt#L451

Upstream has similar changes in 1.4.
[...]
There is no need to generally enable sanitizers in clang debug builds. In static builds, sanitizers impose transitive usage requirements.
The patch is just equivalent to if(0).

I looked at upstream before asking about this and I don't see it:

https://github.com/search?q=repo%3Aopen62541%2Fopen62541+UA_ENABLE_SANITIZER&type=code
https://github.com/search?q=repo%3Aopen62541%2Fopen62541+UA_ENABLE_SANTITIZER&type=code

(Upstream has UA_ENABLE_DEBUG_SANITIZER now.)

Yes, I see open62541/open62541@a820093 , but that's functionally always on in upstream, not off. Though looking now it looks like that stuff should come from the triplet. Unfortunately, patches don't contain all that context :(

[BillyONeal]

Suggested change

	+ UA_ENABLE_SANTITIZER AND
	+ UA_ENABLE_SANITIZER AND

?

[BillyONeal]

Alternately just apply upstream's patch directly to remove any concern?
https://github.com/open62541/open62541/commit/a820093aa97d08334147ecb85d8602f917d4f511.patch?full_index=1

[BillyONeal]

(To be clear I would have just merged this if not for this spelling oops but since a revision is necessary anyway may as well match upstream's name?)

[dg0yt]

"patch does not apply"

[BillyONeal]

😢

[BillyONeal]

Thanks for the update and for fixing Android!