Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open62541] Do not enable LTO by default. #41947

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

17steen
Copy link
Contributor

@17steen 17steen commented Nov 4, 2024

open62541's cmake forces LTO on this is often an issue when software using different compiler / not enabling LTO tries to use this library

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@17steen 17steen changed the title Bugfix/disable lto open62541 [open62541] Do not enable LTO by default. Nov 4, 2024
# Conflicts:
#	ports/open62541/portfile.cmake
#	ports/open62541/vcpkg.json
#	versions/baseline.json
#	versions/o-/open62541.json
@jimwang118 jimwang118 self-assigned this Nov 4, 2024
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 4, 2024
@17steen 17steen requested a review from jimwang118 November 4, 2024 14:30
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Nov 5, 2024
@vicroms vicroms merged commit 9c58903 into microsoft:master Nov 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants