-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mygui] Support dynamic linking for MyGUI #41840
Conversation
OpenMW's also been carrying 6f1c4b5 in our fork, but that looks like it'd be sensible to upstream, too. Do you want it doing in this PR or a separate one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed with vcpkg install mygui[*]:x64-windows
BaseManager.cpp.obj : error LNK2019: unresolved external symbol IMG_Init referenced in function "public: virtual bool __cdecl base::BaseManager::createRender(int,int,bool)"
Available upstream as MyGUI/mygui#271, which isn't merged when I'm writing this, but likely will be by the time anyone reviews this PR again.
This should now be resolved - I'd not built with the tools option enabled. The necessary patch is available upstream as MyGUI/mygui#271, but not yet merged when I'm writing this. There's a good chance that it will be by the time you're reading this, though. |
It's now merged upstream, so this PR should work properly, and only contain changes upstream is happy with. The only remaining question is whether it's preferable to submit 6f1c4b5 as a standalone PR or part of this one. |
Small PRs follow best practices, I think it's better to separate, https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#make-separate-pull-requests-per-port. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port features installation tests pass with the following triplets:
- x64-linux
- x64-linux-static
- x64-windows
- x64-windows-static
The new patch was accepted upstream as MyGUI/mygui#270, but as other lines have changed in one of the affected files, we need a bespoke patch to work with the 3.4.3 release.
Intended to supersede #41800 as that PR isn't useful without the other changes this one makes.
./vcpkg x-add-version --all
and committing the result.