Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mygui] Support dynamic linking for MyGUI #41840

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

AnyOldName3
Copy link
Contributor

@AnyOldName3 AnyOldName3 commented Oct 28, 2024

The new patch was accepted upstream as MyGUI/mygui#270, but as other lines have changed in one of the affected files, we need a bespoke patch to work with the 3.4.3 release.

Intended to supersede #41800 as that PR isn't useful without the other changes this one makes.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@AnyOldName3 AnyOldName3 mentioned this pull request Oct 28, 2024
7 tasks
@AnyOldName3
Copy link
Contributor Author

OpenMW's also been carrying 6f1c4b5 in our fork, but that looks like it'd be sensible to upstream, too. Do you want it doing in this PR or a separate one?

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed with vcpkg install mygui[*]:x64-windows

BaseManager.cpp.obj : error LNK2019: unresolved external symbol IMG_Init referenced in function "public: virtual bool __cdecl base::BaseManager::createRender(int,int,bool)"

ports/mygui/platform-lib-static.patch Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 29, 2024
Available upstream as MyGUI/mygui#271, which isn't merged when I'm writing this, but likely will be by the time anyone reviews this PR again.
@AnyOldName3
Copy link
Contributor Author

Failed with vcpkg install mygui[*]:x64-windows

BaseManager.cpp.obj : error LNK2019: unresolved external symbol IMG_Init referenced in function "public: virtual bool __cdecl base::BaseManager::createRender(int,int,bool)"

This should now be resolved - I'd not built with the tools option enabled. The necessary patch is available upstream as MyGUI/mygui#271, but not yet merged when I'm writing this. There's a good chance that it will be by the time you're reading this, though.

@AnyOldName3
Copy link
Contributor Author

It's now merged upstream, so this PR should work properly, and only contain changes upstream is happy with.

The only remaining question is whether it's preferable to submit 6f1c4b5 as a standalone PR or part of this one.

@WangWeiLin-MV
Copy link
Contributor

The only remaining question is whether it's preferable to submit 6f1c4b5 as a standalone PR or part of this one.

Small PRs follow best practices, I think it's better to separate, https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#make-separate-pull-requests-per-port.

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port features installation tests pass with the following triplets:

  • x64-linux
  • x64-linux-static
  • x64-windows
  • x64-windows-static

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Oct 30, 2024
@vicroms vicroms merged commit 3412a87 into microsoft:master Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants