Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[itk] Revise, test, fix #41525

Merged
merged 29 commits into from
Nov 16, 2024
Merged

[itk] Revise, test, fix #41525

merged 29 commits into from
Nov 16, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 12, 2024

Add test port.
Fix cuda.
Fix pkgconfig.
Drop unofficial debug postfix.
De-vendor vxl.
[rtk]: Update download, patch without warnings.
[vtk]: Fix build with vtk[python].
[fftw]: New optional feature to control GPL dependency. Resolves #35939.
[python]: Move hidden castxml download to new tool port. Enables caching.
Update copyright.
Cleanup.

@MonicaLiu0311 MonicaLiu0311 added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Oct 12, 2024
@dg0yt dg0yt force-pushed the itk branch 2 times, most recently from 08708f1 to e6a3051 Compare October 12, 2024 16:16
@dg0yt dg0yt changed the title [itk] Test and fix [itk] Revise, test, fix Oct 17, 2024
@dg0yt dg0yt force-pushed the itk branch 2 times, most recently from 6782ffd to 9baa29c Compare October 17, 2024 07:30
@dg0yt dg0yt force-pushed the itk branch 2 times, most recently from 4694e39 to 82deaeb Compare October 23, 2024 04:23
@dg0yt dg0yt marked this pull request as ready for review October 24, 2024 07:10
@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 1, 2024

x64-linux regression is unrelated. Fixed in #41893.

Please review now.

@dg0yt dg0yt mentioned this pull request Nov 7, 2024
7 tasks
@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 7, 2024

Unrelated CI failure, fixed by #42017.

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 12, 2024

All checks green.

@MonicaLiu0311
Copy link
Contributor

Features fftw,python,rtk are tested successfully in the following triplet:

x64-windows

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
@vicroms vicroms merged commit b2cb0da into microsoft:master Nov 16, 2024
16 checks passed
@dg0yt dg0yt deleted the itk branch November 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[itk] fftw3 feature
3 participants