Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aliyun-oss-cpp-sdk] Change to find package config mode #40954

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Sep 13, 2024

Related #40597.

Change include(...) to find_package(... CONFIG REQUIRED).

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port usage tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Sep 13, 2024
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/aliyun-oss-cpp-sdk/find-cmake-config branch from 14221a0 to f0a4894 Compare September 13, 2024 09:40
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review September 14, 2024 02:39
JonLiu1993
JonLiu1993 previously approved these changes Sep 14, 2024
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 14, 2024
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @dg0yt. Thanks for the rest of the fixes though!

@BillyONeal BillyONeal marked this pull request as draft September 16, 2024 19:23
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Sep 16, 2024
@BillyONeal
Copy link
Member

This PR might also fix this port failing in the most recent CI, but maybe I'm just dreaming:

CMake Error at sdk/CMakeLists.txt:19 (configure_file):
  No such file or directory


-- Configuring incomplete, errors occurred!

@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/aliyun-oss-cpp-sdk/find-cmake-config branch from f0a4894 to e2d5d3d Compare September 18, 2024 06:44
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review September 18, 2024 07:02
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 19, 2024
@BillyONeal
Copy link
Member

This PR might also fix this port failing in the most recent CI, but maybe I'm just dreaming:

CMake Error at sdk/CMakeLists.txt:19 (configure_file):
  No such file or directory


-- Configuring incomplete, errors occurred!

I apparently was dreaming because it already fixed itself? 🤷

IMG_2752

@BillyONeal BillyONeal merged commit d5ac138 into microsoft:master Sep 19, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix!

@dg0yt
Copy link
Contributor

dg0yt commented Sep 19, 2024

I apparently was dreaming because it already fixed itself? 🤷

No, it is just a race with parallel configure writing to CMAKE_CURRENT_SOURCE_DIR

https://github.com/aliyun/aliyun-oss-cpp-sdk/blob/0632d336ac861816669a1b0eecac30fb8ff71abb/sdk/CMakeLists.txt#L19

@WangWeiLin-MV WangWeiLin-MV deleted the ports/aliyun-oss-cpp-sdk/find-cmake-config branch September 20, 2024 02:37
@WangWeiLin-MV
Copy link
Contributor Author

race with parallel configure writing to CMAKE_CURRENT_SOURCE_DIR

Thanks for your explanation, it's my fault for not noticing this. In view of there are lots of relative references to Config.h upstream, we would mitigate the race via the option DISABLE_PARALLEL_CONFIGURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants