-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aliyun-oss-cpp-sdk] Change to find package config mode #40954
[aliyun-oss-cpp-sdk] Change to find package config mode #40954
Conversation
14221a0
to
f0a4894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @dg0yt. Thanks for the rest of the fixes though!
This PR might also fix this port failing in the most recent CI, but maybe I'm just dreaming: CMake Error at sdk/CMakeLists.txt:19 (configure_file):
No such file or directory
-- Configuring incomplete, errors occurred! |
f0a4894
to
e2d5d3d
Compare
Thanks for the fix! |
No, it is just a race with parallel configure writing to CMAKE_CURRENT_SOURCE_DIR |
Thanks for your explanation, it's my fault for not noticing this. In view of there are lots of relative references to |
Related #40597.
Change
include(...)
tofind_package(... CONFIG REQUIRED)
.Checklist
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory.When updating the upstream version, the"port-version"
is reset (removed fromvcpkg.json
)../vcpkg x-add-version --all
and committing the result.Test
The port usage tests pass with the following triplets: