Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tevclient] Add tevclient port #40532

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

westlicht
Copy link
Contributor

@westlicht westlicht commented Aug 19, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@westlicht
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Cheney-W Cheney-W changed the title Add tevclient port [tevclient] Add tevclient port Aug 19, 2024
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 19, 2024
@Cheney-W
Copy link
Contributor

Regarding the CMakeLists.txt file of this library, I have a few questions:

  1. add_library(tevclient STATIC)

    • Does this library not support dynamic builds? If it does not, please add "supports": "static" in vcpkg.json.
  2. target_link_libraries(tevclient PRIVATE wsock32 ws2_32)

    • Does this library support UWP? If it does not, please add "supports": "!uwp" in vcpkg.json.

@Cheney-W Cheney-W marked this pull request as draft August 19, 2024 10:00
@dg0yt
Copy link
Contributor

dg0yt commented Aug 19, 2024

add_library(tevclient STATIC)

  • Does this library not support dynamic builds? If it does not, please add "supports": "static" in vcpkg.json.

Even if it does not, DO NOT add "supports": "static" in vcpkg.json....
Use vcpkg_check_linkage(ONLY_STATIC_LIBRARY) at the top of the portfile.

@westlicht westlicht marked this pull request as ready for review August 21, 2024 08:26
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Aug 21, 2024
@vicroms vicroms merged commit 62aab9d into microsoft:master Aug 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants