Skip to content

[cmake-user,shiftmedia-libgnutls] Test/fix FindGnuTLS#40473

Merged
data-queue merged 2 commits intomicrosoft:masterfrom
dg0yt:gnutls-ci
Aug 17, 2024
Merged

[cmake-user,shiftmedia-libgnutls] Test/fix FindGnuTLS#40473
data-queue merged 2 commits intomicrosoft:masterfrom
dg0yt:gnutls-ci

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Aug 15, 2024

Fixes #40414.

@dg0yt dg0yt closed this Aug 15, 2024
@dg0yt dg0yt reopened this Aug 15, 2024
@Cheney-W Cheney-W added category:infrastructure Pertaining to the CI/Testing infrastrucutre category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Aug 16, 2024
@dg0yt dg0yt changed the title [cmake-user] Test FindGnuTLS [cmake-user,shiftmedia-libgnutls] Test/fix FindGnuTLS Aug 16, 2024
@dg0yt dg0yt marked this pull request as ready for review August 16, 2024 03:48
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Aug 16, 2024
@data-queue data-queue merged commit 911961e into microsoft:master Aug 17, 2024
@dg0yt dg0yt deleted the gnutls-ci branch August 17, 2024 12:53
vszakats added a commit to curl/curl that referenced this pull request Aug 28, 2024
Starting today vcpkg wants to rebuild GnuTLS but fails:
```
error: building shiftmedia-libgnutls:x64-windows failed with: BUILD_FAILED
```
Ref: https://github.com/curl/curl/actions/runs/10594890318/job/29359499149#step:5:144

Temporary solution:
- drop it from the MultiSSL job.
- replace with mbedTLS job. This job still tests libssh and I could
  not find a better place for it right away.

GnuTLS to be restored once it builds again. Possibly when this hash
reaches the GHA `windows-latest` runner:
microsoft/vcpkg@f5ec6f3

Also:
- switch to Debug for the mbedTLS job. Should also work now with
  GnuTLS, once it's back:
  Ref: microsoft/vcpkg#40473

Closes #14710
@dg0yt dg0yt mentioned this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shiftmedia-libgnutls] Add release dll on debug when compile with ngtcp2 and gnutls

3 participants