Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hlslpp] Add new port #40400

Merged
merged 32 commits into from
Aug 23, 2024
Merged

[hlslpp] Add new port #40400

merged 32 commits into from
Aug 23, 2024

Conversation

plekakis
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@plekakis
Copy link
Contributor Author

plekakis commented Aug 11, 2024 via email

@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 12, 2024
@jimwang118 jimwang118 changed the title Hlslpp port (hlsl++ from https://github.com/redorav/hlslpp) [hlslpp] Add new port Aug 12, 2024
ports/hlslpp/hlslpp-config.cmake Outdated Show resolved Hide resolved
ports/hlslpp/portfile.cmake Outdated Show resolved Hide resolved
ports/hlslpp/usage Outdated Show resolved Hide resolved
ports/hlslpp/vcpkg.json Outdated Show resolved Hide resolved
versions/h-/hlslpp.json Outdated Show resolved Hide resolved
ports/hlslpp/portfile.cmake Outdated Show resolved Hide resolved
@jimwang118
Copy link
Contributor

Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@jimwang118 jimwang118 marked this pull request as draft August 14, 2024 01:54
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most comments don't add value to the command that follow. Just remove them.

The CMake config package is not provided by upstream. The package-name should be prefixed with unofficial-.
https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#add-cmake-exports-in-an-unofficial--namespace
And even for a header-only package, it might make sense to provide an imported target instead of variables.

ports/hlslpp/usage Outdated Show resolved Hide resolved
ports/hlslpp/usage Outdated Show resolved Hide resolved
ports/hlslpp/hlslpp-config.cmake Outdated Show resolved Hide resolved
ports/hlslpp/hlslpp-config.cmake Outdated Show resolved Hide resolved
set(hlslpp_VERSION 3.5)

# Specify include directories
set(hlslpp_INCLUDE_DIRS "${CMAKE_CURRENT_LIST_DIR}/../../include/hlslpp/include")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be nice to place includes in ${CMAKE_CURRENT_LIST_DIR}/../../include/hlslpp?

Comment on lines 1 to 2
# vcpkg_check_linkage(ONLY_STATIC_LIBRARY)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
# vcpkg_check_linkage(ONLY_STATIC_LIBRARY)

ports/hlslpp/portfile.cmake Outdated Show resolved Hide resolved
@plekakis
Copy link
Contributor Author

Apologies for all the above, this is my first vcpkg contribution and I am learning still.
I'm talking to the author of hlslpp and doing this in his place instead, so I would still like this to be an official port - bear with me and will sort it all out properly.

@plekakis plekakis marked this pull request as ready for review August 16, 2024 09:54
…ously cmake would error with 'The target name hlslpp::hlslpp is reserved or not valid'. Updated vcpkg version database
jimwang118
jimwang118 previously approved these changes Aug 19, 2024
@jimwang118
Copy link
Contributor

Usage test pass with following triplet:

x64-windows

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Aug 19, 2024
ports/hlslpp/usage Outdated Show resolved Hide resolved
@jimwang118 jimwang118 mentioned this pull request Aug 19, 2024
11 tasks
@jimwang118 jimwang118 removed the info:reviewed Pull Request changes follow basic guidelines label Aug 19, 2024
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Aug 23, 2024
@vicroms vicroms merged commit 3508985 into microsoft:master Aug 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants