-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtk]: Convert dependencies into default features #40279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Aug 4, 2024
Neumann-A
reviewed
Aug 4, 2024
LilyWangLL
added
the
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
label
Aug 5, 2024
MR raised upstream: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11376 |
LilyWangLL
approved these changes
Aug 9, 2024
Update: Upstream MR was merged 😄 |
data-queue
approved these changes
Aug 13, 2024
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Aug 14, 2024
[vtk]: Convert dependencies into default features (microsoft#40279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves multiple previously mandatory dependencies to be default features instead. This was inspired by, and builds upon, @bansan85's work on #39511 to have
vtk[core]
pull in much less dependencies.Everything is added as a default feature because the dependencies are required for things in the "Standalone" or "Rendering" VTK groups which the portfile has enabled (ie:
VTK_GROUP_ENABLE_StandAlone=YES
). So I take that as the "expected functionality".This could be taken further but I was focused on value-for-effort and seacas was my main target for making non-strictly-required.
I've tested many configurations (if only on Windows) but if anything has problems it'll probably be from paraview or rtabmap; which I was not able to test properly because... they're huge.
Before (vtk[cgns,libharu,libtheora,netcdf,proj,seacas,sql]) -- 48 packages -- 3.67GB
After (vtk[core]) -- 32 packages -- 3.30GB
./vcpkg x-add-version --all
and committing the result.