[ffmpeg] Add feature harfbuzz#40105
Merged
data-queue merged 27 commits intomicrosoft:masterfrom Aug 17, 2024
Merged
Conversation
jimwang118
added
category:port-feature
Contributor
|
Add the feature to vcpkg-ci-ffmpeg for CI coverage. |
dg0yt
reviewed
Jul 26, 2024
| "bzip2", | ||
| "freetype", | ||
| "gpl", | ||
| "harfbuzz", |
Contributor
There was a problem hiding this comment.
Probably it cannot be tested on android. But wait for CI to finish for all triplets before adding platform.
Contributor
Author
There was a problem hiding this comment.
Ok, thanks for your suggestion.
Contributor
There was a problem hiding this comment.
Hm, harfbuzz is present on android, but the config test in ffmpeg fails:
clang @/mnt/vcpkg-ci/b/ffmpeg/arm64-android-rel/ldflags.rsp -L/mnt/vcpkg-ci/installed/arm64-android/lib -Wl,--as-needed -Wl,-z,noexecstack -fPIE -pie -pthread -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../include/harfbuzz -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../include -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../include/libpng16 -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../include -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../include/glib-2.0 -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../lib/glib-2.0/include -I/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../include -L/mnt/vcpkg-ci/installed/arm64-android/lib/pkgconfig/../../lib -pthread -pthread -o /tmp/ffconf.3bddnvpr/test /tmp/ffconf.3bddnvpr/test.o -lharfbuzz -lm -lfreetype -lbz2 -lpng16 -lm -lz -lbrotlidec -lbrotlicommon -lglib-2.0 -lintl -lm -liconv -lpcre2-8 -lm
ld.lld: error: undefined symbol: __gxx_personality_v0
>>> referenced by hb-static.cc
>>> hb-static.cc.o:(DW.ref.__gxx_personality_v0) in archive /mnt/vcpkg-ci/installed/arm64-android/lib/libharfbuzz.a
Probably missing C++ linkage represented in harfbuzz pc files.
dg0yt
reviewed
Jul 26, 2024
Contributor
|
Let's focus on #38011 first. |
Contributor
Author
Ok, i will wait for PR 38011 to be merged, and then continue to modify this PR. |
LilyWangLL
added
the
depends:different-pr
jimwang118
removed
the
depends:different-pr
LilyWangLL
previously approved these changes
Aug 9, 2024
LilyWangLL
added
the
info:needs-maintainer-attention
dg0yt
reviewed
Aug 9, 2024
Contributor
|
Please remove info:reviewed. It is still not ready for merge. |
LilyWangLL
added
info:needs-maintainer-attention
data-queue
reviewed
Aug 15, 2024
data-queue
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40094
Add feature drawtext to enable drawtext function.
Delete the patches that have been merged into the new version upstream.(FFmpeg/FFmpeg@fcfd17d)
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.The feature passed with following triplets: