[vcpkg] fix find_library suffix/prefix definitions for iOS#39972
Merged
data-queue merged 1 commit intomicrosoft:masterfrom Jul 27, 2024
Merged
[vcpkg] fix find_library suffix/prefix definitions for iOS#39972data-queue merged 1 commit intomicrosoft:masterfrom
data-queue merged 1 commit intomicrosoft:masterfrom
Conversation
Contributor
|
The change is okay IMO. But do you expect this to fix an immediate problem? Sane ports shouldn't depend on this anyways. (It is for portfile script mode. Project mode gets a regular CMake toolchain setup, and so |
Contributor
Author
The issue I saw was due to a app I have using a vcpkg manifest dependency on
https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide
|
data-queue
approved these changes
Jul 24, 2024
Cheney-W
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, when building dynamic iOS libs for
mp3lame, the generatedmp3lame-config.cmakewould be erroneously looking forlibmp3lame.ainstead oflibmp3lame.dylib.