Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dav1d] Skip host nasm dependency when targeting non-x86 #39923

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[dav1d] Skip host nasm dependency when targeting non-x86 #39923

merged 1 commit into from
Jul 15, 2024

Conversation

BertalanD
Copy link
Contributor

nasm is only required when targeting x86(_64).

Fixes #39920

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BertalanD
[dav1d] Skip host nasm dependency when targeting non-x86
0d8d397 
`nasm` is only required when targeting x86(_64).

Fixes microsoft#39920
@BertalanD
Copy link
Contributor Author

@microsoft-github-policy-service agree

@LilyWangLL LilyWangLL self-assigned this Jul 15, 2024
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Jul 15, 2024
@JavierMatosD JavierMatosD merged commit 19bf4c0 into microsoft:master Jul 15, 2024
17 checks passed
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dav1d] should not depend on nasm on arm64
3 participants
@BertalanD @JavierMatosD @LilyWangLL