Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cyrus-sasl] new port #39892

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[cyrus-sasl] new port #39892

merged 1 commit into from
Jul 25, 2024

Conversation

timkpaine
Copy link
Contributor

@timkpaine timkpaine commented Jul 12, 2024 •
edited
Loading

Fixes #5894
Leverages #38402
Relates to #37523
Goal: add gssapi support to librdkafka

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@timkpaine timkpaine mentioned this pull request Jul 12, 2024
Open
3 tasks
@timkpaine timkpaine force-pushed the tkp/cyrussasl branch 4 times, most recently from 00ceefc to 0dfad06 Compare July 12, 2024 20:42
@timkpaine timkpaine marked this pull request as ready for review July 12, 2024 20:43
@timkpaine timkpaine changed the title add cyrus-sasl port [cyrus-sasl] new port Jul 12, 2024
@timkpaine timkpaine mentioned this pull request Jul 12, 2024
Merged
7 tasks
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 15, 2024
LilyWangLL
LilyWangLL requested changes Jul 15, 2024
View reviewed changes
ports/cyrus-sasl/portfile.cmake Outdated Show resolved Hide resolved
ports/cyrus-sasl/portfile.cmake Outdated Show resolved Hide resolved
ports/cyrus-sasl/vcpkg.json Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@LilyWangLL LilyWangLL marked this pull request as draft July 15, 2024 02:48
@rinrab
Copy link
Contributor

rinrab commented Jul 15, 2024

I'm waiting for this port :)

@chemodax
Copy link

The win32/README.md in upstream states that NMake files not supported:

nmake makefiles weren't updated for awhile and most likely won't build.

So maybe it makes sense to use msbuild to build SASL on Windows?

@timkpaine
Copy link
Contributor Author

The win32/README.md in upstream states that NMake files not supported:

nmake makefiles weren't updated for awhile and most likely won't build.

So maybe it makes sense to use msbuild to build SASL on Windows?

I'm not going to do that, but I'm happy to drop windows support

@timkpaine timkpaine force-pushed the tkp/cyrussasl branch 2 times, most recently from 85400a8 to edc3fcc Compare July 16, 2024 13:27
@timkpaine timkpaine marked this pull request as ready for review July 16, 2024 15:58
@timkpaine timkpaine requested a review from LilyWangLL July 16, 2024 15:58
LilyWangLL
LilyWangLL requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@LilyWangLL LilyWangLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some format suggestions.

versions/c-/cyrus-sasl.json Outdated Show resolved Hide resolved
ports/cyrus-sasl/portfile.cmake Outdated Show resolved Hide resolved
ports/cyrus-sasl/portfile.cmake Show resolved Hide resolved
@timkpaine timkpaine requested a review from LilyWangLL July 19, 2024 16:24
LilyWangLL
LilyWangLL previously approved these changes Jul 22, 2024
View reviewed changes
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 22, 2024
dg0yt
dg0yt reviewed Jul 22, 2024
View reviewed changes
ports/cyrus-sasl/portfile.cmake Outdated Show resolved Hide resolved
ports/cyrus-sasl/portfile.cmake Outdated Show resolved Hide resolved
ports/cyrus-sasl/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Jul 23, 2024
@timkpaine @LilyWangLL @dg0yt
add cyrus-sasl port
77df27d 
Co-authored-by: Lily Wang <[email protected]>
Co-authored-by: Kai Pastor <[email protected]>
@timkpaine
Copy link
Contributor Author

arm64_osx seems failing for unrelated reasons

@timkpaine timkpaine requested review from dg0yt and LilyWangLL July 23, 2024 17:23
@data-queue
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 24, 2024
@timkpaine
Copy link
Contributor Author

Can this be merged?

@data-queue data-queue merged commit 6474628 into microsoft:master Jul 25, 2024
16 checks passed
@timkpaine timkpaine deleted the tkp/cyrussasl branch July 25, 2024 20:29
@timkpaine
Copy link
Contributor Author

thanks @data-queue !

@rtzoeller rtzoeller mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@data-queue data-queue data-queue approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

@dg0yt dg0yt Awaiting requested review from dg0yt

Assignees

@LilyWangLL LilyWangLL

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New port request] Cyrus SASL
6 participants
@timkpaine @LilyWangLL @rinrab @chemodax @data-queue @dg0yt