Skip to content

[sdl2] Fix exported deps for android#39709

Merged
JavierMatosD merged 3 commits intomicrosoft:masterfrom
dg0yt:ffmpeg-deps
Jul 10, 2024
Merged

[sdl2] Fix exported deps for android#39709
JavierMatosD merged 3 commits intomicrosoft:masterfrom
dg0yt:ffmpeg-deps

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 5, 2024

Extracted from #39703:

  • Some optional sources use C++. pc files don't declare link language. Our established approach is exporting the extra implicit link libraries for C++. (Cf. port lerc and others.)
  • For android, the debug suffix isn't used.

@dg0yt dg0yt changed the title [sdl2,libwebp] Fix exported deps android [sdl2,libwebp] Fix exported deps for android Jul 5, 2024
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Jul 5, 2024
@dg0yt dg0yt changed the title [sdl2,libwebp] Fix exported deps for android [sdl2] Fix exported deps for android Jul 5, 2024
LilyWangLL
LilyWangLL previously approved these changes Jul 8, 2024
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 8, 2024
@dg0yt dg0yt marked this pull request as draft July 9, 2024 07:46
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 9, 2024

Must check #39703 first.

@LilyWangLL LilyWangLL removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 9, 2024
@dg0yt dg0yt marked this pull request as ready for review July 9, 2024 18:18
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 9, 2024

Should be okay. These changes were missing in #39703 after resolving the merge conflicts from the other sdl2 update.

@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 10, 2024
@JavierMatosD JavierMatosD merged commit 5cb8081 into microsoft:master Jul 10, 2024
@dg0yt dg0yt deleted the ffmpeg-deps branch July 10, 2024 19:30
cenit pushed a commit to cenit/vcpkg that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants