[msquic] Rename from ms-quic and remove the tools feature.#39500
Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom Jun 27, 2024
Merged
[msquic] Rename from ms-quic and remove the tools feature.#39500BillyONeal merged 4 commits intomicrosoft:masterfrom
BillyONeal merged 4 commits intomicrosoft:masterfrom
Conversation
As requested by upstream maintainer @nibanks in microsoft#39332 (review) This should probably be after microsoft#39498 makes CI test msquic for more targets.
BillyONeal
added
category:port-bug
BillyONeal
added
the
depends:different-pr
Member
Author
|
I killed the test run since it'll just merge conflict with #39498 anyway |
nibanks
approved these changes
Jun 25, 2024
BillyONeal
removed
the
depends:different-pr
WangWeiLin-MV
approved these changes
Jun 27, 2024
Contributor
WangWeiLin-MV
left a comment
WangWeiLin-MV
left a comment
There was a problem hiding this comment.
The port usage tests pass with the following triplets:
- x64-windows
WangWeiLin-MV
added
the
info:needs-maintainer-attention
Member
Author
|
Thanks for the review @WangWeiLin-MV :) |
| @@ -0,0 +1,9 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
It seems needs to delete versions/m-/ms-quic.json
Contributor
There was a problem hiding this comment.
We need to preserve the version database to allow using older versions in manifest mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by upstream maintainer @nibanks in #39332 (review)
This should probably be after #39498 makes CI test msquic for more targets.