[osg] Add Collada model support to OpenSceneGraph#3950
[osg] Add Collada model support to OpenSceneGraph#3950Codiferous merged 2 commits intomicrosoft:masterfrom
Conversation
|
@calumr Sorry for the tremendous delay in processing this PR -- we're focusing very heavily on processing PRs now! Is the Would this PR be something we could accept without the virtual method patch? |
|
The patch was a hack to work around a crash in daeIOPluginCommon::beginReadElement. When you try to load a .dae file in OSG, it crashes in here and I didn't get the time to debug the issue. I can't recall why I tried making the methods non-virtual, but it worked. I don't have time to investigate a fix right now. If possible I'd prefer to merge without the I could try attaching a minimal test case that reproduces the bug? |
|
Actually I think this is just a case of missing |
|
Okay, this PR is looking pretty good to me! Let's get it merged 😄 Thanks for this, and sorry again for the significant delay in processing this! |
Collada models are .dae files, and are the only open format you can download from 3dwarehouse.sketchup.com.