Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sophus] Update to 1.24.6-rc1 #39225

Merged
merged 4 commits into from
Jun 12, 2024
Merged

[sophus] Update to 1.24.6-rc1 #39225

merged 4 commits into from
Jun 12, 2024

Conversation

strasdat
Copy link
Contributor

No description provided.

@strasdat strasdat marked this pull request as draft June 11, 2024 16:58
ports/sophus/vcpkg.json Outdated Show resolved Hide resolved
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 12, 2024
@jimwang118 jimwang118 changed the title sophus 1.24.06 [sophus] Update to 1.24.06 Jun 12, 2024
ports/sophus/vcpkg.json Outdated Show resolved Hide resolved
@strasdat
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jimwang118
Copy link
Contributor

You need to execute the ./vcpkg x-add-version {portname} command after updating the version, and then submit the generated version file.

@strasdat strasdat force-pushed the master branch 2 times, most recently from fabb2aa to 77c36dc Compare June 12, 2024 06:41
@strasdat strasdat marked this pull request as ready for review June 12, 2024 06:44
@strasdat strasdat force-pushed the master branch 3 times, most recently from dc475ed to 0662859 Compare June 12, 2024 06:54
@strasdat strasdat requested a review from jimwang118 June 12, 2024 06:54
@jimwang118 jimwang118 changed the title [sophus] Update to 1.24.06 [sophus] Update to 1.24.6 Jun 12, 2024
@strasdat
Copy link
Contributor Author

strasdat commented Jun 12, 2024

edit: figured it out

@FrankXie05 I did create a new version for Sophus and it seems to work. Also. out of curiosity, I enabled to build tests to see whether it actual compiles for the target platform.

It looks like all windows builds are failing - I'm not too surprised since I have no windows CI in the base repository yet. The error seems to be:

 fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj

What is the recommended course of action?

@strasdat strasdat changed the title [sophus] Update to 1.24.6 [sophus] Update to 1.24.6-rc1 Jun 12, 2024
@strasdat strasdat force-pushed the master branch 3 times, most recently from aa14fd3 to b63a7e4 Compare June 12, 2024 09:11
jimwang118
jimwang118 previously approved these changes Jun 12, 2024
@strasdat
Copy link
Contributor Author

@jimwang118 I think I might need another approval...

ports/sophus/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal BillyONeal merged commit 1ea2f6a into microsoft:master Jun 12, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jun 13, 2024
@FrankXie05
Copy link
Contributor

edit: figured it out

@FrankXie05 I did create a new version for Sophus and it seems to work. Also. out of curiosity, I enabled to build tests to see whether it actual compiles for the target platform.

It looks like all windows builds are failing - I'm not too surprised since I have no windows CI in the base repository yet. The error seems to be:

 fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj

What is the recommended course of action?

It indicates that the number of sections in the object file has exceeded the limit imposed by the default object file format.

This usually happens in large projects, or when using templates and complex code that generates a large number of sections in the object file.

You can instruct the compiler to use a larger object file format by adding the /bigobj option. :)
eg:
CMake:

if(MSVC)
add_compile_options(/bigobj)
endif()

makefile:

CXXFLAGS += /bigobj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants