Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl dependency to opentelemetry-cpp elasticsearch feature #38878

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

aristotelos
Copy link
Contributor

If curl is not listed as a dependency, the port build fails.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@aristotelos
Copy link
Contributor Author

@microsoft-github-policy-service agree

@aristotelos aristotelos marked this pull request as ready for review May 22, 2024 13:54
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 23, 2024
If `curl` is not listed as a dependency, the port build fails.
@aristotelos
Copy link
Contributor Author

@jimwang118 I see you added the label "port-feature". Isn't this a bug in the port (rather than a feature) because it does not specify required dependencies?

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels May 23, 2024
@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Jun 12, 2024
@BillyONeal BillyONeal merged commit eb0f108 into microsoft:master Jun 12, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix!

@aristotelos aristotelos deleted the patch-1 branch June 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants