Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVR] Updated to version 2.5.1 #38554

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

DeltaW0x
Copy link
Contributor

@DeltaW0x DeltaW0x commented May 3, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@DeltaW0x
Copy link
Contributor Author

DeltaW0x commented May 3, 2024

@microsoft-github-policy-service agree

@Cheney-W Cheney-W changed the title Updated OpenVR to version 2.5.1 [OpenVR] Updated to version 2.5.1 May 6, 2024
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label May 6, 2024
@Cheney-W Cheney-W marked this pull request as draft May 6, 2024 10:20
@Cheney-W
Copy link
Contributor

Cheney-W commented May 6, 2024

I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@DeltaW0x DeltaW0x marked this pull request as ready for review May 7, 2024 20:23
@Cheney-W
Copy link
Contributor

Cheney-W commented May 8, 2024

The new error is because you didn't execute the .\vcpkg.exe x-add-version openvr --overwrite-version command locally after committing the new changes. This caused the content of the openvr.json file to become incorrect.

@Cheney-W
Copy link
Contributor

Cheney-W commented May 8, 2024

However, my comment was just a suggestion, and whether to adopt it depends on you. So, since you've reverted your change, consider it as if you didn't adopt my suggestion.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 8, 2024
@data-queue data-queue merged commit 7aa9416 into microsoft:master May 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants