-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-cpp] Update to 1.13.0 #35996
[opentelemetry-cpp] Update to 1.13.0 #35996
Conversation
I used the following command locally: .\vcpkg.exe install opentelemetry-cpp[*] when testing the feature installation, the following error occurred.
|
Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags. |
3d28760
to
49c6e13
Compare
@jimwang118 This error was because of a change in opentelemetry-cpp 1.13 that stopped defining |
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in: open-telemetry/opentelemetry-cpp#2268 Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release. A patch is added extracted from open-telemetry/opentelemetry-cpp#2475 and open-telemetry/opentelemetry-cpp#2449 which fix problems that arose after `NOMINMAX` was no longer defined within opentelemetry-cpp on Windows. Fixes microsoft#35992.
49c6e13
to
a3937b6
Compare
Updated again to include open-telemetry/opentelemetry-cpp#2449 to fix one more |
All features passed with following triplets:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The android build lab appears to be broken and I only made whitespace changes so I'll merge this if all other platforms come back OK |
The patch to add a dependency of opentelemetry-proto on gRPC should not be needed after the upstream changes in:
open-telemetry/opentelemetry-cpp#2268
Additionally, the "zpages" feature is removed as it is no longer present upstream after having been deprecated in a previous release.
Fixes #35992.
./vcpkg x-add-version --all
and committing the result.Might be best to have this reviewed by someone that uses this more or who knows more about the upstream.