Skip to content

[vcpkg-scripts][gmp][nettle] Use VSCLANG#35335

Closed
dg0yt wants to merge 4 commits intomicrosoft:masterfrom
dg0yt:vsclang
Closed

[vcpkg-scripts][gmp][nettle] Use VSCLANG#35335
dg0yt wants to merge 4 commits intomicrosoft:masterfrom
dg0yt:vsclang

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 26, 2023

Cherry-picked and revised from #31228:
Use clang from Visual Studio for assembler or fail with a clear error message. Don't download llvm

For #28912 and several similar reports.

@Neumann-A
Copy link
Contributor

I am against this. There is no reason to force clang from VS.

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 26, 2023

I am against this. There is no reason to force clang from VS.

Only against not accepting another installed clang (via LLVMInstallDir, or even from downloads/tools),
or against not downloading LLVM?

@Neumann-A
Copy link
Contributor

I am against forcing clang from VS. So if it is not installed you could print a info message and then go get LLVM. LLVMInstallDir is not passed through so you never see that variable in normal triplets.

I mean the current behavior is already -> get clang -> if installed in VS use that -> otherwise download llvm and use that. (Third way: Have the variable set in the triplet and directly feed it.)

@Adela0814 Adela0814 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Nov 27, 2023
@dg0yt dg0yt closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants