Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt5-base] fix arm64 compiling #35120

Closed
wants to merge 2 commits into from
Closed

[qt5-base] fix arm64 compiling #35120

wants to merge 2 commits into from

Conversation

FrankXie05
Copy link
Contributor

Fix #35031

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 15, 2023
@FrankXie05 FrankXie05 marked this pull request as ready for review November 16, 2023 02:52
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 20, 2023
@data-queue
Copy link
Contributor

Is there an upstream PR?

@data-queue data-queue marked this pull request as draft November 22, 2023 02:55
@data-queue data-queue removed the info:reviewed Pull Request changes follow basic guidelines label Nov 22, 2023
@dg0yt
Copy link
Contributor

dg0yt commented Nov 22, 2023

I doubt upstream is active about (open-source) Qt5.

@FrankXie05
Copy link
Contributor Author

Is there an upstream PR?

https://bugreports.qt.io/browse/QTBUG-119340

@FrankXie05 FrankXie05 added the depends:upstream-changes Waiting on a change to the upstream project label Nov 28, 2023
@shijunz
Copy link

shijunz commented Apr 11, 2024

Is there an upstream PR?

https://bugreports.qt.io/browse/QTBUG-119340

so, what is news? how about the patch? it is mainlined at the vcpkg now? I try to vcpkg install qt5-webengine:arm64-windows, I get the same issue.

@MonicaLiu0311
Copy link
Contributor

Is there any new progress?

@FrankXie05
Copy link
Contributor Author

Closed by #41536

@FrankXie05 FrankXie05 closed this Dec 5, 2024
@FrankXie05 FrankXie05 deleted the dev/Frank/35031 branch December 5, 2024 09:48
@CodingCanuck CodingCanuck mentioned this pull request Dec 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[qt5-base] Build error
5 participants
@FrankXie05 @data-queue @dg0yt @shijunz @MonicaLiu0311