[mongo-c-driver/libbson] update to 1.25.0#34865
Closed
Adela0814 wants to merge 3 commits intomicrosoft:masterfrom
Closed
[mongo-c-driver/libbson] update to 1.25.0#34865Adela0814 wants to merge 3 commits intomicrosoft:masterfrom
Adela0814 wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Adela0814
added
info:internal
category:port-update
kevinAlbs
reviewed
Nov 16, 2023
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Suggest applying commits from this branch to fix the windows_static tasks.
| "${CURRENT_PACKAGES_DIR}/share/mongo-c-driver" | ||
| ) | ||
|
|
||
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") |
Contributor
There was a problem hiding this comment.
libbson 1.25.0 supports an ENABLE_SHARED option. I suggest applying kevinAlbs@736861d to conditionally disable dynamic libbson.
| SHA512 e35878eed6fe56a383eeb07795bcb6bfbaa29cd3d63c0efd67748e10982c9c1294c2de2127471b1f154ea658747c3a98e8d9f9a1cbcf1f5bf4ec6aa6e7b276a6 | ||
| HEAD_REF master | ||
| PATCHES | ||
| disable-dynamic-when-static.patch |
Contributor
There was a problem hiding this comment.
At present, there is no option to disable dynamic libmongoc (refer: CDRIVER-4784). I suggest applying kevinAlbs@b20bf0d to add a patch to conditionally disable dynamic libmongoc.
Contributor
|
Duplicate of #34994. This PR upgrades |
Contributor
|
#34994 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34855
All feature tested pass on the following triplets:
Usage tested pass on
x64-windows.The "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file../vcpkg x-add-version --alland committing the result.