[GEOS] Generate debug library names with d suffix#3371
Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom May 1, 2018
mloskot:ml/geos-debug-use-postfix-d
Merged
[GEOS] Generate debug library names with d suffix#3371ras0219-msft merged 2 commits intomicrosoft:masterfrom mloskot:ml/geos-debug-use-postfix-d
d suffix#3371ras0219-msft merged 2 commits intomicrosoft:masterfrom
mloskot:ml/geos-debug-use-postfix-d
Conversation
Currently geos.lib name is used for both, debug and optimised GEOS libraries. This leads to situation when: ``` find_library(GEOS_LIBRARY_DEBUG NAMES geos) find_library(GEOS_LIBRARY_RELEASE NAMES geos) ``` finds the same library for both ``` GEOS_LIBRARY_DEBUG=D:/vcpkg/installed/x64-windows/debug/lib/geos.lib GEOS_LIBRARY_RELEASE=D:/vcpkg/installed/x64-windows/debug/lib/geos.lib ``` This is minimal patch that works around the problem. Next, complete fix should be submitted to GEOS upstream, preferably using exported targets.
Contributor
|
Thanks for the PR! I also fixed up the references for libspatialite's static build. |
Contributor
Author
|
@ras0219-msft Thank you! |
Contributor
|
2 years later...
Now I would like to know which direction to take, starting from #17616, and aiming at fixing geos for Unix (#9068). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to current port of GEOS 3.6.2
Follows discussion on Slack hannel #vcpkg
Currently geos.lib name is used for both, debug and optimised
GEOS libraries. This leads to situation when:
finds the same library for both
This is minimal patch that works around the problem.
Next, complete fix should be submitted to GEOS upstream,
preferably using exported targets.