Skip to content

[duktape] remove skipped triplets from ci.baseline#33054

Closed
Adela0814 wants to merge 2 commits intomicrosoft:masterfrom
Adela0814:Dev/Mengna/duktape
Closed

[duktape] remove skipped triplets from ci.baseline#33054
Adela0814 wants to merge 2 commits intomicrosoft:masterfrom
Adela0814:Dev/Mengna/duktape

Conversation

@Adela0814
Copy link
Contributor

@Adela0814 Adela0814 commented Aug 9, 2023

Fixes #14741
Added by #10030. This issue is too old, and I have tested that the new version can already run successfully on osx, so I removed the skipped triplets in ci.baseline.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Aug 9, 2023
@Adela0814 Adela0814 changed the title [duktape] add osx support [duktape] remove skipped triplets from ci.baseline Aug 9, 2023
@BillyONeal
Copy link
Member

Given that neither duktape nor our osx fleet have changed, I doubt anything has changed here.

@xiaozhuai
Copy link
Contributor

@BillyONeal
Copy link
Member

See svaarala/duktape#1794 (comment)

Sure, but the port would have to change to call the changed thing, and I don't see evidence of that.

@Adela0814 Adela0814 closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[duktape] pyyaml installation fails on macOS (does not block port installing)

5 participants