Skip to content

[cpprestsdk] use platform expressions in default-features#32998

Merged
JavierMatosD merged 3 commits intomicrosoft:masterfrom
autoantwort:cpprestsdk-default-features
Aug 7, 2023
Merged

[cpprestsdk] use platform expressions in default-features#32998
JavierMatosD merged 3 commits intomicrosoft:masterfrom
autoantwort:cpprestsdk-default-features

Conversation

@autoantwort
Copy link
Contributor

This uses the new feature from microsoft/vcpkg-tool#813.

One "problem" is that people with old vcpkg-tool versions will get an error if they want to use the port and there is afaik not way to tell them that they have to update vcpkg-tool.

@jimwang118
Copy link
Contributor

Install microsoft-signalr first and the following problems will occur when installing signalrclient.

Installing 1/1 signalrclient:x64-windows...
error: The following files are already installed in F:/cpprestsdk/installed/x64-windows and are in conflict with signalrclient:x64-windows
Installed by microsoft-signalr:x64-windows
include/signalrclient/_exports.h
    include/signalrclient/connection_state.h
    include/signalrclient/hub_connection.h
    include/signalrclient/hub_exception.h
    include/signalrclient/log_writer.h
    include/signalrclient/trace_level.h
    include/signalrclient/transport_type.h
    include/signalrclient/web_exception.h

Elapsed time to handle signalrclient:x64-windows: 13.6 ms

@jimwang118
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@jimwang118 jimwang118 marked this pull request as draft August 7, 2023 06:14
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 7, 2023
@autoantwort
Copy link
Contributor Author

Install microsoft-signalr first and the following problems will occur when installing signalrclient.

This is not new:

# Conflicts with signalrclient
microsoft-signalr:arm64-windows=skip
microsoft-signalr:arm-uwp=skip
microsoft-signalr:x64-linux=skip
microsoft-signalr:x64-osx=skip
microsoft-signalr:arm64-osx=skip
microsoft-signalr:x64-uwp=skip
microsoft-signalr:x64-windows=skip
microsoft-signalr:x64-windows-static=skip
microsoft-signalr:x64-windows-static-md=skip
microsoft-signalr:x86-windows=skip

@autoantwort autoantwort marked this pull request as ready for review August 7, 2023 09:32
@jimwang118 jimwang118 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 7, 2023
@JavierMatosD JavierMatosD merged commit 6da00e1 into microsoft:master Aug 7, 2023
@autoantwort autoantwort deleted the cpprestsdk-default-features branch August 7, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants