Conversation
|
|
||
| # Temporary mitigation for build being stuck for unclear reasons, | ||
| # https://github.com/microsoft/vcpkg/issues/29018 | ||
| if(EXISTS "${SCRIPTS}/cmake/vcpkg_install_meson.cmake") |
There was a problem hiding this comment.
Avoiding a hard dependency on this filepath.
ports/gtk3/portfile.cmake
Outdated
| if(EXISTS "${SCRIPTS}/cmake/vcpkg_install_meson.cmake") | ||
| file(READ "${SCRIPTS}/cmake/vcpkg_install_meson.cmake" install_meson) | ||
| string(REPLACE [[COMMAND "${NINJA}"]] [[ | ||
| TIMEOUT 3600 |
There was a problem hiding this comment.
Change to 5 if you want to verify the effect.
|
@ras0219-msft @markle11m @dan-shaw @JavierMatosD We discussed this PR and feel that this is better implemented as a general build timeout in the vcpkg executable. Any build that is taking longer than the timeout causes vcpkg to stop so that CI has time to upload logs. The timeout should be a user setting and we can pick a value that works for our CI (the team thinks 5 hours should be OK). @ras0219-msft also points out that the current implementation of the timeout is not good since it couples the implementation of |
|
When will it come? |
Now using 5 hours.
Already done in a way which should degrade gracefully. |
Mitigation for #29018.
From proper failures, we will be able to get CI logs for port gtk3.
CC @BillyONeal.
./vcpkg x-add-version --alland committing the result.