Skip to content

Conversation

@MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 commented Jun 29, 2023

Fixed CI pipeline issue:

PASSING, REMOVE FROM FAIL LIST: colmap:x86-windows
PASSING, REMOVE FROM FAIL LIST: colmap:x64-windows
PASSING, REMOVE FROM FAIL LIST: colmap:x64-windows-static
PASSING, REMOVE FROM FAIL LIST: colmap:x64-windows-static-md

PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x86-windows
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-windows
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-windows-static
PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-windows-static-md

PASSING, REMOVE FROM FAIL LIST: llfio:x64-linux

PASSING, REMOVE FROM FAIL LIST: mfl:x64-linux

PASSING, REMOVE FROM FAIL LIST: mp-units:arm-neon-android
PASSING, REMOVE FROM FAIL LIST: mp-units:x64-android
PASSING, REMOVE FROM FAIL LIST: mp-units:arm64-android
  • Added colmap and graphicsmagick to ci.baseline.txt in #23011 and #26283 due to the ICE for VS2022, it has been fixed on the latest release of VS 2022, so removed the following records.

    # there is an ICE in VS2022 with colmap in release mode
    colmap:x86-windows=fail
    colmap:x64-windows=fail
    colmap:x64-windows-static=fail
    colmap:x64-windows-static-md=fail
    
    graphicsmagick:x64-windows-static-md=fail
    graphicsmagick:x64-windows-static=fail
    graphicsmagick:x64-windows=fail
    graphicsmagick:x86-windows=fail
    
  • Added llfio to ci.baseline.txt in #25560 due to outdated gcc version, it has been fixed by #22504, so remove the following records.

    # fails due to an outdated gcc version
    llfio:x64-linux=fail
    

    Added mfl to ci.baseline.txt in #30102 due to c++20 compiler required, it has been fixed by #32014, so removed the following records.

    mfl:x64-linux=fail # requires a c++20 compiler
    
  • Added mp-units to ci.baseline.txt in #29406 due to Clang 13 and below require the dependency range-v3, it was fixed by #32028, so removed the following records.

    mp-units:arm-neon-android=fail
    mp-units:arm64-android=fail
    mp-units:x64-android=fail
    
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jun 29, 2023
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review July 3, 2023 07:46
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 3, 2023
@vicroms vicroms merged commit 45482ed into microsoft:master Jul 5, 2023
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_pipelines branch July 6, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants