Skip to content

[CURL] fix an error on find_package(CURL CONFIG) for debug library#3220

Closed
miurahr wants to merge 3 commits intomicrosoft:masterfrom
miurahr:ports_curl_find_error_debuglib
Closed

[CURL] fix an error on find_package(CURL CONFIG) for debug library#3220
miurahr wants to merge 3 commits intomicrosoft:masterfrom
miurahr:ports_curl_find_error_debuglib

Conversation

@miurahr
Copy link
Contributor

@miurahr miurahr commented Apr 7, 2018

Fixed #3053

miurahr added 3 commits April 7, 2018 13:00
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- sync with code for fixing a problem in cmake project.
https://gitlab.kitware.com/cmake/cmake/merge_requests/1940

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@past-due
Copy link
Contributor

A quick note:
@miurahr's fix for this in CMake itself was merged into CMake's master branch about 1 month ago.
It did not make it into CMake 3.12.x, but it looks like it'll be in CMake 3.13.0.

@miurahr
Copy link
Contributor Author

miurahr commented Aug 16, 2018

@past-due Thanks for note.
bcedb02 is as same FindCURL.cmake as CMake 3.13.0, which is my fix. For interim solution, I'd like to propose to bundle it.

@Neumann-A
Copy link
Contributor

this pr should be closed.
a) fixed in newer CMake and with #6386

@miurahr miurahr closed this May 19, 2019
@miurahr
Copy link
Contributor Author

miurahr commented May 19, 2019

@Neumann-A thanks.

Grumbel added a commit to Grumbel/supertux that referenced this pull request Mar 15, 2022
According to these links the issue should and the workaround no longer
necessary:

* microsoft/vcpkg#3220
* microsoft/vcpkg#1909
Grumbel added a commit to Grumbel/supertux that referenced this pull request Mar 16, 2022
According to these links the issue should be fixed and the workaround
no longer necessary:

* microsoft/vcpkg#3220
* microsoft/vcpkg#1909
Grumbel added a commit to SuperTux/supertux that referenced this pull request Mar 16, 2022
According to these links the issue should be fixed and the workaround
no longer necessary:

* microsoft/vcpkg#3220
* microsoft/vcpkg#1909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CURL] error on find_package(CURL CONFIG)

3 participants