Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libuv] Update to 1.45.0 #32072

Closed
wants to merge 0 commits into from
Closed

Conversation

ralpioxxcs
Copy link
Contributor

Updates libuv 1.44.2 -> 1.45.0

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@ralpioxxcs
Copy link
Contributor Author

@microsoft-github-policy-service agree

@ralpioxxcs ralpioxxcs marked this pull request as ready for review June 17, 2023 09:11
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 19, 2023
ports/libuv/usage Outdated Show resolved Hide resolved
@MonicaLiu0311
Copy link
Contributor

Please get failure logs here. Please ping me if you need any help.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft June 21, 2023 02:13
@ralpioxxcs
Copy link
Contributor Author

@dg0yt Patches all consuming ports using old target name (uv, uv_a).

@ralpioxxcs ralpioxxcs marked this pull request as ready for review June 21, 2023 11:44
@dg0yt
Copy link
Contributor

dg0yt commented Jun 21, 2023

Great. However I think you need to restore some lines in the version tree. The PR must not change the existing version records.

@ralpioxxcs ralpioxxcs force-pushed the master branch 2 times, most recently from e6755f8 to 3262888 Compare June 21, 2023 13:35
@ralpioxxcs
Copy link
Contributor Author

ralpioxxcs commented Jun 21, 2023

The PR must not change the existing version records.

I think there was a problem applying the vcpkg command (./vcpkg x-add-version --all), now I fixed it.
Thank you for your review! @dg0yt

@ralpioxxcs ralpioxxcs closed this Jun 22, 2023
@ralpioxxcs ralpioxxcs force-pushed the master branch 2 times, most recently from 3262888 to b8d272a Compare June 22, 2023 06:54
@ralpioxxcs ralpioxxcs mentioned this pull request Jun 22, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants