Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indirect-value] add new port #32019

Merged
merged 6 commits into from
Jun 17, 2023
Merged

Conversation

jiayuehua
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

ports/indirect-value/portfile.cmake Outdated Show resolved Hide resolved
ports/indirect-value/usage Outdated Show resolved Hide resolved
@jiayuehua jiayuehua marked this pull request as ready for review June 15, 2023 07:05
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 15, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passed (header files found):

The package indirect-value provides CMake targets:

    find_package(indirect_value CONFIG REQUIRED)
    target_link_libraries(main PRIVATE indirect_value::indirect_value)

@MonicaLiu0311 MonicaLiu0311 changed the title [indirect-value]: add new port [indirect-value] add new port Jun 16, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jun 16, 2023
@vicroms vicroms merged commit 537780d into microsoft:master Jun 17, 2023
@jiayuehua jiayuehua deleted the indirect_value branch October 5, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants