Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flashlight-sequence] New port #31914

Merged
merged 7 commits into from
Jun 13, 2023
Merged

Conversation

jacobkahn
Copy link
Contributor

@jacobkahn jacobkahn commented Jun 9, 2023

Adds a port for Flashlight Sequence (https://github.com/flashlight/sequence). Features include:

  • cuda -- build CUDA kernels with the package
  • openmp -- build with OpenMP support

Tested ports on all platforms/features except for x64-windows (with CUDA), but we have a CI baseline for this -- https://app.circleci.com/pipelines/github/flashlight/sequence/65/workflows/3af72357-b9a7-4d66-aa58-5fa65892243b/jobs/526


  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Sorry, something went wrong.

@jacobkahn jacobkahn marked this pull request as ready for review June 9, 2023 21:16
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 12, 2023
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@JonLiu1993 JonLiu1993 marked this pull request as draft June 12, 2023 07:43
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
@jacobkahn jacobkahn marked this pull request as ready for review June 12, 2023 16:08
@jacobkahn jacobkahn requested a review from JonLiu1993 June 12, 2023 16:08
@JonLiu1993
Copy link
Member

Tested all features successfully in the following triplet:

  • x64-windows
  • x64-windows-static
    Tested usage successfully by flashlight-sequence:x64-windows:
Total install time: 39 s
flashlight-sequence provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(flashlight-sequence CONFIG REQUIRED)
    target_link_libraries(main PRIVATE flashlight::flashlight-sequence)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 13, 2023
@vicroms vicroms merged commit c35a7c0 into microsoft:master Jun 13, 2023
@jacobkahn jacobkahn deleted the flashlight-sequence branch June 13, 2023 21:20
facebook-github-bot pushed a commit to flashlight/sequence that referenced this pull request Jun 13, 2023
Summary:
Pending microsoft/vcpkg#31914 being merged.

Pull Request resolved: #15

Test Plan: visual inspection

Reviewed By: EntilZha

Differential Revision: D46603380

Pulled By: jacobkahn

fbshipit-source-id: 7b9065822b79e5fd02b0051fc6940e45111d3791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants