Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[games101-cgl] new port #31831

Merged
merged 13 commits into from
Jun 14, 2023
Merged

[games101-cgl] new port #31831

merged 13 commits into from
Jun 14, 2023

Conversation

endingly
Copy link
Contributor

@endingly endingly commented Jun 5, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@endingly
Copy link
Contributor Author

endingly commented Jun 5, 2023

@microsoft-github-policy-service agree

@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 6, 2023
@endingly
Copy link
Contributor Author

endingly commented Jun 7, 2023

@Cheney-W Please wait for a few days. There are some issues with this library now.

@Cheney-W Cheney-W marked this pull request as draft June 7, 2023 07:58
@Cheney-W
Copy link
Contributor

Cheney-W commented Jun 7, 2023

Moving the PR to draft. Please set it to "ready for review" once issues have been solved.

@endingly endingly marked this pull request as ready for review June 12, 2023 11:59
@endingly
Copy link
Contributor Author

@Cheney-W Ready to review

versions/baseline.json Outdated Show resolved Hide resolved
@Cheney-W Cheney-W marked this pull request as draft June 13, 2023 05:43
@Cheney-W
Copy link
Contributor

Could you please release a tag from https://github.com/endingly/games101-cgl and use the tag instead of the commit id?

@endingly endingly marked this pull request as ready for review June 13, 2023 07:42
@Cheney-W Cheney-W marked this pull request as draft June 14, 2023 02:40
@Cheney-W
Copy link
Contributor

Moving the PR to draft. Please set it to "ready for review" once changes have been applied.

@endingly endingly marked this pull request as ready for review June 14, 2023 08:41
@Cheney-W
Copy link
Contributor

Usage passed with following triplets:

x86-windows 
x64-windows 
x64-windows-static 

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 14, 2023
@vicroms vicroms merged commit 3056fed into microsoft:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants