[baresip-libre] Add new port #31735

alfredh · 2023-05-31T07:11:30Z

JonLiu1993 · 2023-06-01T09:22:17Z

@alfredh, Thanks for your PR, I tested the usage locally failed by libre:x64-windows but get this error.
Please take a look:

1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\v-zhli17\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/libre/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\Users\v-zhli17\source\repos\usageTest" 2>&1"
1> Working directory: C:\Users\v-zhli17\source\repos\usageTest\out\build\x64-Debug
1> [CMake] -- The C compiler identification is MSVC 19.36.32532.0
1> [CMake] -- The CXX compiler identification is MSVC 19.36.32532.0
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] CMake Error at F:/Feature-test/libre/vcpkg/scripts/buildsystems/vcpkg.cmake:853 (_find_package):
1> [CMake]   Could not find a package configuration file provided by "libre" with any of
1> [CMake]   the following names:
1> [CMake] 
1> [CMake]     libreConfig.cmake
1> [CMake]     libre-config.cmake
1> [CMake] 
1> [CMake]   Add the installation prefix of "libre" to CMAKE_PREFIX_PATH or set
1> [CMake]   "libre_DIR" to a directory containing one of the above files.  If "libre"
1> [CMake]   provides a separate development package or SDK, be sure it has been
1> [CMake]   installed.
1> [CMake] Call Stack (most recent call first):
1> [CMake]   usageTest/CMakeLists.txt:6 (find_package)
1> [CMake] -- Configuring incomplete, errors occurred!
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\v-zhli17\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/libre/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\Users\v-zhli17\source\repos\usageTest" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\v-zhli17\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" -DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/libre/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\Users\v-zhli17\source\repos\usageTest" 2>&1"' returned with exit code: 1'.

CMakeLists.txt:

	 cmake_minimum_required(VERSION 3.18)
	
	 project(versionstest2)
	
	 find_package(libre CONFIG REQUIRED)

	 add_executable(main usageTest.cpp)

	 target_link_libraries(main PRIVATE libre::re)

JonLiu1993 · 2023-06-01T09:23:01Z

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

alfredh · 2023-06-04T11:08:27Z

here are my files after "vcpkg install libre":

alfredh@debian:~/tmp/vcpkg$ tree installed/x64-linux/share/libre/
installed/x64-linux/share/libre/
├── copyright
├── re-config.cmake
├── usage
├── vcpkg_abi_info.txt
└── vcpkg.spdx.json

0 directories, 5 files




alfredh@debian:~/tmp/vcpkg$ ./vcpkg owns libre
libre:x64-linux: x64-linux/debug/lib/libre.a
libre:x64-linux: x64-linux/debug/lib/pkgconfig/libre.pc
libre:x64-linux: x64-linux/lib/libre.a
libre:x64-linux: x64-linux/lib/pkgconfig/libre.pc
libre:x64-linux: x64-linux/share/libre/copyright
libre:x64-linux: x64-linux/share/libre/re-config.cmake
libre:x64-linux: x64-linux/share/libre/usage
libre:x64-linux: x64-linux/share/libre/vcpkg.spdx.json
libre:x64-linux: x64-linux/share/libre/vcpkg_abi_info.txt

dg0yt · 2023-06-04T14:30:20Z

x64-linux/share/libre/re-config.cmake

This is not going to work.

For package name re: It won't be found in dir libre.
For package name libre: It won't be found with the re-config.cmake name.

vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/re)

So the config comes from dir re. It needs to go dir re:

vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/re PACKAGE_NAME re)

Yes, the parameter is PACKAGE_NAME, but in fact it is the output directory name. The default value is the port name. vcpkg_cmake_config_fixup is a little bit stupid, at least until #31053.

alfredh · 2023-06-06T11:46:21Z

hi, thanks for your comment. I updated the code as suggested.

dg0yt · 2023-06-06T20:52:01Z

Don't forget to mark the PR as ready for review when you are done.

JonLiu1993 · 2023-06-07T10:11:01Z

@alfredh, I tested usage again but also failed:

CMakeLists:

cmake_minimum_required(VERSION 3.16)
project(min-vcpkg-tiff-test)


find_package(libre CONFIG REQUIRED)

add_executable(main usageTest.cpp)

target_link_libraries(main PRIVATE libre::re)

1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"
1> Working directory: C:\Users\test\source\repos\usageTest\out\build\x64-Debug
1> [CMake] -- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
1> [CMake] -- The C compiler identification is MSVC 19.36.32532.0
1> [CMake] -- The CXX compiler identification is MSVC 19.36.32532.0
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] CMake Error at F:/test/vcpkg/scripts/buildsystems/vcpkg.cmake:853 (_find_package):
1> [CMake]   Could not find a package configuration file provided by "libre" with any of
1> [CMake]   the following names:
1> [CMake] 
1> [CMake]     libreConfig.cmake
1> [CMake]     libre-config.cmake
1> [CMake] 
1> [CMake]   Add the installation prefix of "libre" to CMAKE_PREFIX_PATH or set
1> [CMake]   "libre_DIR" to a directory containing one of the above files.  If "libre"
1> [CMake]   provides a separate development package or SDK, be sure it has been
1> [CMake]   installed.
1> [CMake] Call Stack (most recent call first):
1> [CMake]   usageTest/CMakeLists.txt:5 (find_package)
1> [CMake] -- Configuring incomplete, errors occurred!
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Visual Studio 17 2022" -A x64  -DCMAKE_CONFIGURATION_TYPES:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\test\source\repos\usageTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE=F:/test/vcpkg/scripts/buildsystems/vcpkg.cmake "C:\Users\test\source\repos\usageTest" 2>&1"' returned with exit code: 1'.

dg0yt · 2023-06-07T13:14:04Z

It is:

find_package(re CONFIG REQUIRED)

ports/libre/usage

dg0yt · 2023-06-07T13:15:41Z

ports/libre/usage

+The package libre is compatible with built-in CMake targets:
+
+    find_package(libre CONFIG REQUIRED)
+    target_link_libraries(main PRIVATE libre::re)


Which namespace does it use?

See example usage from testcode here: https://github.com/baresip/re/blob/main/test/CMakeLists.txt#L62

alfredh · 2023-06-08T10:01:10Z

many thanks for review and testing.

I have updated the "usage" text.

We have added the namespace "libre" but for some reason I dont think it is working.
In the existing testcode we also use "re" which works.

dg0yt · 2023-06-10T06:22:53Z

Oh, re-config.cmake isn't exported CMake config. You need help with CMake ...

dg0yt · 2023-06-10T09:36:31Z

... instead of review comments:
https://github.com/alfredh/vcpkg/pull/1

alfredh · 2023-06-12T08:32:23Z

Many thanks for your patch, I have applied it to this PR.

There are some checks failing, currently around 5 failing checks, including
arm64_android, x64_windows etc...

dg0yt · 2023-06-12T10:59:52Z

ports/libre/wip.patch

+ URL: @CMAKE_PROJECT_HOMEPAGE_URL@
+-Libs: -L${libdir} -lre
+-Libs.private: -L${libdir} -lre -ldl -lssl -lcrypto -lz -lpthread
+Libs: -L${libdir} -lre@PC_LIBNAME_SUFFIX@


-+Libs: -L${libdir} -lre@PC_LIBNAME_SUFFIX@ ++Libs: -L${libdir} -l@PC_LIBNAME@

(Slipped through, but only affects MSVC.)

JonLiu1993 · 2023-06-16T08:01:44Z

@alfredh, I tested usage again but also failed:

1> [CMake] -- Configuring done (14.4s)
1> [CMake] CMake Error at F:/Feature-test/libre/vcpkg/installed/x64-windows/share/libre/libre-config.cmake:21 (set_target_properties):
1> [CMake]   The link interface of target "libre::libre" contains:
1> [CMake] 
1> [CMake]     libre::re_shared
1> [CMake] 
1> [CMake]   but the target was not found.  Possible reasons include:
1> [CMake] 
1> [CMake]     * There is a typo in the target name.
1> [CMake]     * A find_package call is missing for an IMPORTED target.
1> [CMake]     * An ALIAS target is missing.

alfredh · 2023-06-17T10:40:42Z

hi, which platform are you building for?

Please note that for Windows we only support .lib files and no .dll files:

if(VCPKG_TARGET_IS_WINDOWS)
    vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endif()

Do you have the testprogram and command, so I can test it locally ?

JonLiu1993 · 2023-06-19T01:43:42Z

hi, which platform are you building for?

Please note that for Windows we only support .lib files and no .dll files:
if(VCPKG_TARGET_IS_WINDOWS)
    vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
endif()
Do you have the testprogram and command, so I can test it locally ?

The libre:x64-windows I tested, the simple CMakeLists file tested is the same as last time:
#31735 (comment)

alfredh · 2023-06-19T06:49:57Z

Hi, I have tested on arm64-osx and it appears to be working:

Alfreds-MBP-M1:tmp alfredh$ cmake -DCMAKE_TOOLCHAIN_FILE=/Users/alfredh/tmp/vcpkg/scripts/buildsystems/vcpkg.cmake .
-- The C compiler identification is AppleClang 14.0.0.14000029
-- The CXX compiler identification is AppleClang 14.0.0.14000029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Found OpenSSL: /Users/alfredh/tmp/vcpkg/installed/arm64-osx/debug/lib/libcrypto.a (found version "3.1.1")  
-- Found ZLIB: /Users/alfredh/tmp/vcpkg/installed/arm64-osx/lib/libz.a (found version "1.2.13") 
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/alfredh/tmp


Alfreds-MBP-M1:tmp alfredh$ make
[ 50%] Building CXX object CMakeFiles/main.dir/usageTest.cpp.o
[100%] Linking CXX executable main
[100%] Built target main


Alfreds-MBP-M1:tmp alfredh$ ./main 
version 3.2.0

CMake file:

cmake_minimum_required(VERSION 3.16)
project(min-vcpkg-tiff-test)


find_package(libre CONFIG REQUIRED)

add_executable(main usageTest.cpp)

target_link_libraries(main PRIVATE libre::re)

usageTest.cpp:

#include <re.h>


int main()
{
	libre_init();

	re_printf("version %s\n", sys_libre_version_get());
}

JonLiu1993 · 2023-06-19T06:54:59Z

@alfredh, Could you please test it on regular windows platform? Such as libre:X64-windows? Because most users use the windows platform.

dg0yt · 2023-06-19T07:34:00Z

ports/libre/wip.patch

+    elseif(TARGET libre::re AND (NOT BUILD_SHARED_LIBS OR NOT TARGET libre::re_shared))
+        add_library(libre::libre INTERFACE IMPORTED)
+        set_target_properties(libre::libre PROPERTIES INTERFACE_LINK_LIBRARIES libre::re_shared)


The usage error comes from this line which should use libre::re instead of libre::re_shared.

alfredh · 2023-06-19T08:34:44Z

thanks Kai, I updated the patch and pushed the changes.

I also tested the usage locally with triplet x64-linux:

alfredh@debian:~/tmp$ cmake -DCMAKE_TOOLCHAIN_FILE=/home/alfredh/tmp/vcpkg/scripts/buildsystems/vcpkg.cmake .
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Found OpenSSL: /home/alfredh/tmp/vcpkg/installed/x64-linux/debug/lib/libcrypto.a (found version "3.1.0")  
-- Found ZLIB: /home/alfredh/tmp/vcpkg/installed/x64-linux/lib/libz.a (found version "1.2.13") 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/alfredh/tmp
alfredh@debian:~/tmp$ make
[ 50%] Building CXX object CMakeFiles/main.dir/usageTest.cpp.o
[100%] Linking CXX executable main
[100%] Built target main
alfredh@debian:~/tmp$ ./main 
version 3.2.0

JonLiu1993 · 2023-06-19T09:18:43Z

Tested usage successfully by libre:x64-windows:

libre provides CMake targets:

    find_package(libre CONFIG REQUIRED)
    target_link_libraries(main PRIVATE libre::libre)

ports/libre/vcpkg.json

alfredh · 2023-06-23T09:54:22Z

Hi,

I have renamed the project as suggested.

Is there any chance to merge this PR soon ?

Br,
Alfred

alfredh · 2023-06-24T13:17:27Z

Great, thank you all for help and review!

alfredh added 2 commits May 31, 2023 09:10

libre 3.2.0

e292360

update hash

a42a38a

FrankXie05 assigned JonLiu1993 May 31, 2023

JonLiu1993 changed the title ~~libre 3.2.0~~ [libre] Add new port May 31, 2023

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 31, 2023

JonLiu1993 marked this pull request as draft June 1, 2023 09:23

alfredh added 2 commits June 4, 2023 21:29

vcpkg_cmake_config_fixup: add PACKAGE_NAME

e7c0690

update hash

764c1d9

dg0yt reviewed Jun 7, 2023

View reviewed changes

alfredh added 3 commits June 8, 2023 11:50

Merge branch 'microsoft:master' into master

b5af6e6

update usage:

03fca6e

See example usage from testcode here: https://github.com/baresip/re/blob/main/test/CMakeLists.txt#L62

update hash

24e85fd

alfredh added 2 commits June 12, 2023 09:15

patch from Kai

6b2d69a

update hash

78245a2

alfredh mentioned this pull request Jun 12, 2023

patch from VCPKG project (thanks Kai Pastor) baresip/re#845

Closed

Merge branch 'microsoft:master' into master

46a1516

dg0yt suggested changes Jun 12, 2023

View reviewed changes

patch: fix Libs (thanks Kai)

c3a2a45

alfredh added 3 commits June 15, 2023 09:18

update patch

9ace256

update hash

2bd7e28

Merge branch 'microsoft:master' into master

72152ed

alfredh marked this pull request as ready for review June 15, 2023 07:24

JonLiu1993 marked this pull request as draft June 16, 2023 08:01

Merge branch 'microsoft:master' into master

e8f7e6d

dg0yt reviewed Jun 19, 2023

View reviewed changes

alfredh added 2 commits June 19, 2023 10:31

patch: fix bug with libre::re_shared (thanks Kai)

4730a94

update hash

60935c2

alfredh marked this pull request as ready for review June 19, 2023 11:18

JonLiu1993 previously approved these changes Jun 20, 2023

View reviewed changes

JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 20, 2023

vicroms requested changes Jun 22, 2023

View reviewed changes

ports/libre/vcpkg.json Outdated Show resolved Hide resolved

alfredh added 3 commits June 23, 2023 08:40

Merge branch 'microsoft:master' into master

9ccd9ec

rename from libre to baresip-libre

7e1ddbe

update hash

52fe33b

alfredh dismissed JonLiu1993’s stale review via 52fe33b June 23, 2023 09:38

delete libre.json

eaa250b

alfredh changed the title ~~[libre] Add new port~~ [baresip-libre] Add new port Jun 23, 2023

vicroms approved these changes Jun 23, 2023

View reviewed changes

vicroms merged commit d9e62b5 into microsoft:master Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[baresip-libre] Add new port #31735

[baresip-libre] Add new port #31735

alfredh commented May 31, 2023 •

edited

Loading

JonLiu1993 commented Jun 1, 2023

JonLiu1993 commented Jun 1, 2023

alfredh commented Jun 4, 2023

dg0yt commented Jun 4, 2023

alfredh commented Jun 6, 2023

dg0yt commented Jun 6, 2023

JonLiu1993 commented Jun 7, 2023

dg0yt commented Jun 7, 2023

dg0yt Jun 7, 2023

alfredh commented Jun 8, 2023

dg0yt commented Jun 10, 2023

dg0yt commented Jun 10, 2023

alfredh commented Jun 12, 2023

dg0yt Jun 12, 2023

JonLiu1993 commented Jun 16, 2023

alfredh commented Jun 17, 2023

JonLiu1993 commented Jun 19, 2023

alfredh commented Jun 19, 2023

JonLiu1993 commented Jun 19, 2023

dg0yt Jun 19, 2023

alfredh commented Jun 19, 2023

JonLiu1993 commented Jun 19, 2023

alfredh commented Jun 23, 2023

alfredh commented Jun 24, 2023

[baresip-libre] Add new port #31735

[baresip-libre] Add new port #31735

Conversation

alfredh commented May 31, 2023 • edited Loading

JonLiu1993 commented Jun 1, 2023

JonLiu1993 commented Jun 1, 2023

alfredh commented Jun 4, 2023

dg0yt commented Jun 4, 2023

alfredh commented Jun 6, 2023

dg0yt commented Jun 6, 2023

JonLiu1993 commented Jun 7, 2023

dg0yt commented Jun 7, 2023

dg0yt Jun 7, 2023

Choose a reason for hiding this comment

alfredh commented Jun 8, 2023

dg0yt commented Jun 10, 2023

dg0yt commented Jun 10, 2023

alfredh commented Jun 12, 2023

dg0yt Jun 12, 2023

Choose a reason for hiding this comment

JonLiu1993 commented Jun 16, 2023

alfredh commented Jun 17, 2023

JonLiu1993 commented Jun 19, 2023

alfredh commented Jun 19, 2023

JonLiu1993 commented Jun 19, 2023

dg0yt Jun 19, 2023

Choose a reason for hiding this comment

alfredh commented Jun 19, 2023

JonLiu1993 commented Jun 19, 2023

alfredh commented Jun 23, 2023

alfredh commented Jun 24, 2023

alfredh commented May 31, 2023 •

edited

Loading