Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wmipp] Update to 1.2.0 #31583

Merged
merged 4 commits into from
May 24, 2023
Merged

[wmipp] Update to 1.2.0 #31583

merged 4 commits into from
May 24, 2023

Conversation

sonodima
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@sonodima sonodima marked this pull request as ready for review May 23, 2023 09:01
@@ -3,7 +3,7 @@ vcpkg_from_github(
REPO sonodima/wmipp
REF "v${VERSION}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this blank line?

@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@Adela0814 Adela0814 marked this pull request as draft May 23, 2023 09:44
@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label May 23, 2023
@sonodima sonodima marked this pull request as ready for review May 23, 2023 11:54
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label May 24, 2023
@dan-shaw dan-shaw merged commit 28d4723 into microsoft:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants