-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpp-async] Add new port #31523
[cpp-async] Add new port #31523
Conversation
The upstream repository uses a vcpkg manifest (https://github.com/microsoft/cpp-async/blob/main/vcpkg.json) but I think the manifests in this repository are independent, right? |
@davidmatson Are official versioned releases planned for cpp-async? If yes, would you suggest that we wait for the first release before publishing a vcpkg port? This PR is using date-based versioning at the moment since there is no official release yet. |
Good question. I was planning on publishing a separate release zip, but I could tag the current branch as v1.0.0. Thoughts? And thanks for doing this port! |
If there are official releases, a release tag would make a lot of sense, yes.
Thank you for publishing the library. ;) |
Done - it's v1.0.0 now. |
This adds the cpp-async library as a new port.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.